Project

General

Profile

Actions

Bug #2384

closed

KeyChain regressions: impossible to create KeyChain using custom TPM/PIB

Added by Alex Afanasyev almost 10 years ago. Updated almost 10 years ago.

Status:
Closed
Priority:
Immediate
Category:
Security
Target version:
Start date:
01/15/2015
Due date:
% Done:

100%

Estimated time:

Description

ndn-cxx:commit:4154634058a33b1c1b89198af568bdefa1a88fea moved implementation of template<class KeyChainTraits> KeyChain(KeyChainTraits traits); which defeated the purpose of that method.

KeyChain, PIB, TPM needs some refactoring to allow embedding custom PIB/TPM types


Related issues 1 (0 open1 closed)

Related to ndn-cxx - Task #2242: Pair up SecPublicInfo and SecTpmClosedYingdi Yu11/30/2014

Actions
Actions #1

Updated by Junxiao Shi almost 10 years ago

Which commit are you talking about? I can't find this commit on Gerrit.

Actions #2

Updated by Alex Afanasyev almost 10 years ago

  • Description updated (diff)
Actions #3

Updated by Junxiao Shi almost 10 years ago

I agree with this issue. Please be sure to put a comment above the function definition about why it shall stay in header, so that the same mistake won't happen in the future.

Actions #4

Updated by Alex Afanasyev almost 10 years ago

I will create a test case to handle the issue in the future.

Actions #5

Updated by Alex Afanasyev almost 10 years ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 100
Actions #6

Updated by Alex Afanasyev almost 10 years ago

  • Description updated (diff)
Actions #7

Updated by Alex Afanasyev almost 10 years ago

Unfortunately, it wasn't possible to just move constructor into the header file. I did some refactoring of the PIB/TPM creation process.

Actions #8

Updated by Alex Afanasyev almost 10 years ago

  • Status changed from In Progress to Closed
Actions #9

Updated by Alex Afanasyev almost 10 years ago

  • Related to Task #2242: Pair up SecPublicInfo and SecTpm added
Actions

Also available in: Atom PDF