Bug #2384
closed
KeyChain regressions: impossible to create KeyChain using custom TPM/PIB
Added by Alex Afanasyev almost 10 years ago.
Updated almost 10 years ago.
Description
ndn-cxx:commit:4154634058a33b1c1b89198af568bdefa1a88fea moved implementation of template<class KeyChainTraits> KeyChain(KeyChainTraits traits); which defeated the purpose of that method.
KeyChain, PIB, TPM needs some refactoring to allow embedding custom PIB/TPM types
Which commit are you talking about? I can't find this commit on Gerrit.
- Description updated (diff)
I agree with this issue. Please be sure to put a comment above the function definition about why it shall stay in header, so that the same mistake won't happen in the future.
I will create a test case to handle the issue in the future.
- Status changed from New to In Progress
- % Done changed from 0 to 100
- Description updated (diff)
Unfortunately, it wasn't possible to just move constructor into the header file. I did some refactoring of the PIB/TPM creation process.
- Status changed from In Progress to Closed
- Related to Task #2242: Pair up SecPublicInfo and SecTpm added
Also available in: Atom
PDF
Updated by 
Updated by