Project

General

Profile

Actions

Bug #2385

closed

Inconsistent interface / use of interface in PIB

Added by Alex Afanasyev almost 10 years ago. Updated over 9 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
Category:
Security
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

What I'm observing:

  • there is protected getScheme() method that is pure virtual in PIB interface
  • there is non-virtual getPibLocator() method in PIB interface
  • there is private getScheme() method in Sqlite PIB
  • there is virtual getPibLocator() in Sqlite PIB

I'm not sure how this compiles...


Related issues 2 (0 open2 closed)

Blocked by ndn-cxx - Feature #2451: New Abstraction for Identity Key CertificateClosedYingdi Yu01/29/2015

Actions
Blocks ndn-cxx - Task #2926: Refactor KeyChainClosedYingdi Yu

Actions
Actions #1

Updated by Yingdi Yu almost 10 years ago

  • Status changed from New to Code review
  • % Done changed from 0 to 100
Actions #2

Updated by Junxiao Shi almost 10 years ago

@Yingdi Yu, please explain what should be the correct API.

Actions #3

Updated by Yingdi Yu almost 10 years ago

For getPibLocator(), after the commit http://gerrit.named-data.net/#/c/1641/, the getPibLocator is no longer needed in any sub-class of SecPublicInfo.

For SecPublicInfoSqlite3::getScheme(), we keep it protected which is consistent as SecPublicInfo::getScheme().

Actions #4

Updated by Junxiao Shi over 9 years ago

  • Description updated (diff)
Actions #5

Updated by Yingdi Yu over 9 years ago

  • Blocked by Feature #2451: New Abstraction for Identity Key Certificate added
Actions #6

Updated by Yingdi Yu over 9 years ago

Actions #7

Updated by Yingdi Yu over 9 years ago

I cannot find the commit for this one. No idea why I changed it to code review.

This problem does not exist in the new Pib implementation, given we plan to replace the Pib implementation, I would reopen this issue and close it when we finish the refactoring.

Actions #8

Updated by Yingdi Yu over 9 years ago

  • % Done changed from 100 to 0
Actions #9

Updated by Yingdi Yu over 9 years ago

Can some one change the state to in progress. I only have two options: code review and closed

Actions #10

Updated by Junxiao Shi over 9 years ago

  • Status changed from Code review to Rejected

This issue is no longer relevant because PIB interface has been changed.

Actions

Also available in: Atom PDF