Bug #2385
closed
Inconsistent interface / use of interface in PIB
Added by Alex Afanasyev almost 10 years ago.
Updated over 9 years ago.
Description
What I'm observing:
- there is protected getScheme() method that is pure virtual in PIB interface
- there is non-virtual getPibLocator() method in PIB interface
- there is private getScheme() method in Sqlite PIB
- there is virtual getPibLocator() in Sqlite PIB
I'm not sure how this compiles...
- Status changed from New to Code review
- % Done changed from 0 to 100
@Yingdi Yu, please explain what should be the correct API.
For getPibLocator(), after the commit http://gerrit.named-data.net/#/c/1641/, the getPibLocator is no longer needed in any sub-class of SecPublicInfo.
For SecPublicInfoSqlite3::getScheme(), we keep it protected which is consistent as SecPublicInfo::getScheme().
- Description updated (diff)
- Blocked by Feature #2451: New Abstraction for Identity Key Certificate added
I cannot find the commit for this one. No idea why I changed it to code review.
This problem does not exist in the new Pib implementation, given we plan to replace the Pib implementation, I would reopen this issue and close it when we finish the refactoring.
- % Done changed from 100 to 0
Can some one change the state to in progress. I only have two options: code review and closed
- Status changed from Code review to Rejected
This issue is no longer relevant because PIB interface has been changed.
Also available in: Atom
PDF
Updated by 
Updated by