Feature #2420
closed
gerrit: Allowing +1/-1 verified permission for all registered users
0%
Description
Right now, only project owners and build bots are authorized to set +1/-1 verified status on changes. In some cases, it is desirable that other users manually set such status.
One issue with allowing everybody to -1/+1 is that -1 permission will block the merge: it is possible to do this merge only by going around code review system and directly pushing to the internal git repo (I'm not sure I have enabled that for project owners, administrator can do that).
Alternative to all registered users, this feature can be enabled to all known registered users.
Updated by
Updated by Junxiao Shi over 10 years ago
This opens a possibility of Change getting merged without passing Jenkins: before Jenkins build completes, the Change Owner could ask another user to verify (which is likely less comprehensive than Jenkins), and the Change could get merged before Jenkins posts a (possibly) failing result.
If this Feature would be implemented, another rule is needed: for a Jenkins-enabled project, a Verified+1 from Jenkins is required before merging.
This rule should be enforced mechanically by program, and should not solely depend on reviewer.