NFD » ndn-cxx

The intended is to convert the return to a if statement converting the result into -1, 0, 1?

note-1 is correct.

What about alternative solution: change documentation. I'm not aware of anybody actually comparing to +/- 1 and just any negative, 0, or any positive value is perfectly fine result for name::Component::compare.

change documentation

The documented behavior can be implemented correctly and efficiently, so there's no reason to loosen requirements.

I disagree. It was an error to define behavior that narrowly in the documentation. An equivalent for this operation (and what this method was modeled against) is std::string::compare that defines the return value as <0, 0, or >0.

We should fix documentation error, not enforce unnecessarily defined strictness in the docs.

If we decide to loosen the spec to negative/zero/positive, same should apply to Name::compare, and the last return in Name::compare impl could be changed to return count1 - count2;.

I prefer updating all specs, including Name::compare and anything else that explicitly defines -1, 0, and +1

Here is the link with the changes suggested.

http://gerrit.named-data.net/2087

See if the documentation looks correct now.