Task #2449
closed
Remove `tests/utility/test-face-controller.cpp` test case
0%
Description
The existing TestFaceController suite has two test cases: FaceCreateCanonize and FaceCreateFailure.
I don't know what suppose to be done in the second one, but if it is just about canonization failures than the following comment applies to it as well.
It is not NLSR's job to test code in ndn-cxx library. The code is already covered by library's unit tests. If you think something is missing from tests, please submit code to ndn-cxx directly, but not implement tests inside NLSR.
As of right now, master branch does not pass unit tests on some platforms. This is the reason I'm marking this issue as high priority.
Updated by Alex Afanasyev over 10 years ago
- Has duplicate Bug #2498: FaceCreateCanonize in test-face-controller.cpp fails due to IPv4/IPv6 support assumption added
Updated by Vince Lehman over 10 years ago
- Assignee set to Vince Lehman
The FaceCreateCanonize test is testing whether a face create command is sent after a successful canonization.
I could rewrite the tests so that the onSuccess method is manually called instead of in response to a canonization attempt.
Updated by Alex Afanasyev over 10 years ago
Then use canonized face (udp4://1.1.1.1:6363). This way you wouldn't depend on any external thing.