Feature #2553
closed
Block::fromBuffer use move semantics
Added by Junxiao Shi about 9 years ago. Updated about 9 years ago.
100%
Description
Change signature of Block::fromBuffer from
static bool Block::fromBuffer(..., Block&);
to
static std::tuple<bool, Block> Block::fromBuffer(...);
Old syntax becomes deprecated after this API change.
Updated by Junxiao Shi about 9 years ago
- Blocks Feature #2261: Don't use exceptions in PartialMessageStore::receiveNdnlpData added
Updated by Junxiao Shi about 9 years ago
- Status changed from New to In Progress
- Assignee set to Junxiao Shi
Updated by Junxiao Shi about 9 years ago
- % Done changed from 0 to 50
- Estimated time changed from 1.00 h to 1.50 h
http://gerrit.named-data.net/1797
Upcoming commits (of this issue):
- check and fix owned projects
- put
DEPRECATEDmacro
Future version (as separate issue):
- delete deprecated overloads
Updated by Junxiao Shi about 9 years ago
- Blocks deleted (Feature #2261: Don't use exceptions in PartialMessageStore::receiveNdnlpData)
Updated by Junxiao Shi about 9 years ago
- Status changed from In Progress to Resolved
- % Done changed from 50 to 100
ndn-cxx put on DEPRECATED macro http://gerrit.named-data.net/1822
NFD fix http://gerrit.named-data.net/1823
repo-ng fix http://gerrit.named-data.net/1824
Notice is sent to ndn-lib nfd-dev with deadline Mar 08 12:00 UTC.
Updated by Junxiao Shi about 9 years ago
- Status changed from Resolved to Code review
Deadline has passed. The Change should be merged now without further waiting, to prevent other projects introduce new usages of deprecated overloads.
Updated by Junxiao Shi about 9 years ago
<!--
In reply to @Alex's review comment:
I see no rush in merging this.
The Change is uploaded in full compliance with project policy.
There's no reason for ANY delay.
It is a rush to merge this Change, and any other completed Change that complies with project policy.
I prefer this commit to be merged much later, closer to the release of 0.4.
The deprecation notice sent to ndn-lib and nfd-dev is a promise that this Change will merge on a date shortly after the deadline.
There's no reason for ANY further delay.
At least not until we synchronize/path ndnSIM 2.0.
- ndn-cxx-breaks has proven that this Change does not break ndnSIM https://travis-ci.org/yoursunny/ndn-cxx-breaks/builds/53906392.
- If there's a hidden issue, it should have been raised BEFORE the deadline as a reply-all to the deprecation notice.
- If there's a hidden issue, the relevant Bug should be created in ndnSIM and that Bug should block this Feature, and this should have been done BEFORE the deadline.
Therefore, I request to merge this Change now.
Otherwise, my further contribution to ndn-cxx will be throttled until this Change is merged.
-->
(there was rant here; it's now hidden)
Updated by Junxiao Shi about 9 years ago
- Status changed from Code review to Closed
Change is merged. Thanks for approving.
Updated by Junxiao Shi about 9 years ago
- Blocks Task #2636: Delete deprecated Block::fromBuffer overloads added
Updated by Junxiao Shi about 9 years ago
- Status changed from Closed to In Progress
- % Done changed from 100 to 90
I'm sorry but ndn-cxx-breaks didn't detect that NFD is still using a deprecate overload in daemon/face/ndnlp-partial-message-store.cpp.
I'll upload the fix in one hour, and refine ndn-cxx-breaks to avoid the same problem.
Updated by Junxiao Shi about 9 years ago
- Status changed from In Progress to Code review
- % Done changed from 90 to 100
NFD fix: http://gerrit.named-data.net/1857
ndn-cxx-breaks didn't catch the problem because it builds NFD in release mode so warnings aren't errors.
It now builds NFD in debug mode, and catches the error as expected: https://travis-ci.org/yoursunny/ndn-cxx-breaks/builds/54129155.
Updated by Junxiao Shi about 9 years ago
- Status changed from Code review to Closed