Bug #2563
closed
Multicast faces are reported as point-to-point
100%
Description
nfd-status -f shows all faces, including multicast ones, as "point-to-point". IIUC multicast faces should be reported as "multi-access".
There are actually two bugs here:
Face::copyStatusTodoes not set the flag inFaceTraits, which therefore defaults toLINK_TYPE_POINT_TO_POINT.EthernetFacedoes not overrideisMultiAccessto returntrue(butMulticastUdpFacedoes).
Updated by Davide Pesavento almost 10 years ago
- Status changed from New to In Progress
- Assignee set to Davide Pesavento
I'm also wondering... isMultiAccess and isLocal are similar properties, i.e. they both indicate a trait of the face that cannot change during its lifetime (as opposed to an administrative setting that can be changed later on, such as isOnDemand). Yet they're implemented in different ways. isMultiAccess is a virtual getter method, while isLocal is a member field set via a constructor argument and with a non-virtual getter. Can we be more uniform?
Updated by Alex Afanasyev almost 10 years ago
I agree with Davide that we should be consistent and I like the idea of defining non-virtual getter for isMultiAccess (+ constructor argument for face classes)
Updated by Davide Pesavento almost 10 years ago
- Status changed from In Progress to Code review
- % Done changed from 0 to 40
First part: http://gerrit.named-data.net/1809
Updated by Junxiao Shi almost 10 years ago
- Status changed from Code review to In Progress
Status shall be kept in "In Progress" until the final commit is uploaded.
Updated by Davide Pesavento almost 10 years ago
- Status changed from In Progress to Code review
- % Done changed from 40 to 100
Updated by Junxiao Shi almost 10 years ago
- Status changed from Code review to Closed