Bug #2563: Multicast faces are reported as point-to-point - NFD - NDN project issue tracking system

Actions

Copy link

Bug #2563

closed

Multicast faces are reported as point-to-point

Added by Davide Pesavento over 9 years ago. Updated over 9 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Davide Pesavento

Category:

Faces

Target version:

v0.4

Start date:

Due date:

% Done:

100%

Estimated time:

Description

nfd-status -f shows all faces, including multicast ones, as "point-to-point". IIUC multicast faces should be reported as "multi-access".

There are actually two bugs here:

Face::copyStatusTo does not set the flag in FaceTraits, which therefore defaults to LINK_TYPE_POINT_TO_POINT.
EthernetFace does not override isMultiAccess to return true (but MulticastUdpFace does).

Actions

Copy link

Updated by Davide Pesavento over 9 years ago

Status changed from New to In Progress
Assignee set to Davide Pesavento

I'm also wondering... isMultiAccess and isLocal are similar properties, i.e. they both indicate a trait of the face that cannot change during its lifetime (as opposed to an administrative setting that can be changed later on, such as isOnDemand). Yet they're implemented in different ways. isMultiAccess is a virtual getter method, while isLocal is a member field set via a constructor argument and with a non-virtual getter. Can we be more uniform?

Actions

Copy link

Updated by Alex Afanasyev over 9 years ago

I agree with Davide that we should be consistent and I like the idea of defining non-virtual getter for isMultiAccess (+ constructor argument for face classes)

Actions

Copy link