Project

General

Profile

Actions

Bug #2832

closed

TCP/UDP tunnel scenario: wrong output parsing

Added by Junxiao Shi over 9 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
High
Assignee:
Category:
Integration Tests
Target version:
Start date:
05/24/2015
Due date:
% Done:

100%

Estimated time:
1.00 h

Description

test_tcp_udp_tunnel scenario is failing with:

Expected no Interest Loss. Actual: 0.000000%
For more information, please examine the log at "/home/integ/integration-tests/test_tcp_udp_tunnel/logs"

client.log says:

Total Interests Sent        = 100
Total Responses Received    = 100
Total Interest Loss         = 0.000000%

The scenario script does not correctly parse the output, and mistakenly concludes the scenario as failed.


Files

result_2100,2.tar (90 KB) result_2100,2.tar Junxiao Shi, 06/09/2015 04:30 PM
result_2100,3.tar (90 KB) result_2100,3.tar Junxiao Shi, 06/10/2015 08:21 AM
Actions #1

Updated by Junxiao Shi over 9 years ago

  • Assignee set to Davide Pesavento

The offending commit is ndn-traffic-generator:commit:d0b59982c4e6d602ee901c29e2472a1a447d545e, authored by @Davide.

In this commit, boost::lexical_cast<std::string>(loss) is changed to std::to_string(loss), which changes the output format.

The following snippet illustrates the format change:

// g++ -o x -std=c++0x x.cpp $(pkg-config --cflags --libs libndn-cxx)
#include <iostream>
#include <boost/lexical_cast.hpp>

int
main(int argc, char** argv)
{
  double x = 0.0;

  std::cout << boost::lexical_cast<std::string>(x) << std::endl;
  std::cout << std::to_string(x) << std::endl;

  return 0;
}

Output:

shijunxiao@m0212:~/snippet$ ./x
0
0.000000
Actions #2

Updated by Junxiao Shi over 9 years ago

test_unixface scenario is failing for the same reason.

Actions #3

Updated by Davide Pesavento over 9 years ago

The integration tests shouldn't be so strict when parsing output. Where's the repo with the scripts?

Actions #4

Updated by Junxiao Shi over 9 years ago

Where's the repo with the scripts?

Look for it on Gerrit. It exists on Gerrit only.

Actions #5

Updated by Eric Newberry over 9 years ago

  • Status changed from New to In Progress
  • Assignee changed from Davide Pesavento to Eric Newberry
Actions #6

Updated by Eric Newberry over 9 years ago

  • Status changed from In Progress to Code review
Actions #9

Updated by Junxiao Shi over 9 years ago

  • Status changed from Code review to Closed
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF