Bug #2832
closed
TCP/UDP tunnel scenario: wrong output parsing
Added by Junxiao Shi over 9 years ago.
Updated over 9 years ago.
Category:
Integration Tests
Description
test_tcp_udp_tunnel scenario is failing with:
Expected no Interest Loss. Actual: 0.000000%
For more information, please examine the log at "/home/integ/integration-tests/test_tcp_udp_tunnel/logs"
client.log
says:
Total Interests Sent = 100
Total Responses Received = 100
Total Interest Loss = 0.000000%
The scenario script does not correctly parse the output, and mistakenly concludes the scenario as failed.
Files
- Assignee set to Davide Pesavento
The offending commit is ndn-traffic-generator:commit:d0b59982c4e6d602ee901c29e2472a1a447d545e, authored by @Davide.
In this commit, boost::lexical_cast<std::string>(loss)
is changed to std::to_string(loss)
, which changes the output format.
The following snippet illustrates the format change:
// g++ -o x -std=c++0x x.cpp $(pkg-config --cflags --libs libndn-cxx)
#include <iostream>
#include <boost/lexical_cast.hpp>
int
main(int argc, char** argv)
{
double x = 0.0;
std::cout << boost::lexical_cast<std::string>(x) << std::endl;
std::cout << std::to_string(x) << std::endl;
return 0;
}
Output:
shijunxiao@m0212:~/snippet$ ./x
0
0.000000
test_unixface scenario is failing for the same reason.
The integration tests shouldn't be so strict when parsing output. Where's the repo with the scripts?
Where's the repo with the scripts?
Look for it on Gerrit. It exists on Gerrit only.
- Status changed from New to In Progress
- Assignee changed from Davide Pesavento to Eric Newberry
- Status changed from In Progress to Code review
- Status changed from Code review to Closed
- % Done changed from 0 to 100
Also available in: Atom
PDF