Actions
Task #2883
closedNDNLPv2 design: NACK in client Face
Start date:
Due date:
% Done:
100%
Estimated time:
3.00 h
Updated by Junxiao Shi almost 10 years ago
- Related to Task #2763: NDNLPv2: NACK, Fragmentation, NextHopFaceId, CachePolicy, IncomingFaceId added
Updated by Junxiao Shi almost 10 years ago
- Subject changed from Face: Network NACK design to NDNLPv2 design: NACK in client Face
- Status changed from New to In Progress
Updated by Junxiao Shi almost 10 years ago
- Description updated (diff)
- % Done changed from 0 to 20
Updated by Junxiao Shi almost 10 years ago
- Status changed from In Progress to Resolved
- % Done changed from 20 to 100
Updated by Junxiao Shi almost 10 years ago
20150617 conference call reviewed revision 565e09af25b894d45ad5ff2e576ed2864c5371ae.
Comments are:
DataCallback NackCallback TimeoutCallback
should haveconst Interest& interest
parameter.- Semantically, Interest and Data/Nack/timeout form a pair.
- In implementation, the Interest is stored in the PIT, so there's no additional cost to pass it to the callback.
put
shouldn't requireshared_ptr
. Instead, it should takeconst Nack&
and always make a copy (so that caller doesn't need to keep the Nack unchanged.
Updated by Junxiao Shi almost 10 years ago
https://gist.github.com/yoursunny/2c1ce576cd23c9b8b817/b70328e239a893b5d817ff9f007794463f570435 addresses note-5 comments.
Updated by Junxiao Shi almost 10 years ago
- Status changed from Resolved to Closed
20150619 conference call approves the design.
Updated by Junxiao Shi almost 10 years ago
- Blocks Feature #2930: Face: send and receive NACK added
Updated by Junxiao Shi almost 10 years ago
- Blocked by Task #1372: Replace usages of deadline_timer with Scheduler-based events added
Updated by Junxiao Shi almost 10 years ago
- Status changed from Closed to Feedback
Reopening because #1372 adds Scheduler
and deleter
to PendingInterest
struct, so this design needs to be updated accordingly.
Updated by Junxiao Shi almost 10 years ago
- Status changed from Feedback to Closed
Updated by Eric Newberry almost 10 years ago
How does the deprecated expressInterest()
still work if PendingInterest
and FaceImpl
are both modified to only work with the new API?
Updated by Junxiao Shi almost 10 years ago
Answer to note-13:
const PendingInterestId*
Face::expressInterest(const Interest& interest,
const OnData& onData,
const OnTimeout& onTimeout)
{
return this->expressInterest(
interest,
[onData] (const Interest& interest, const Data& data) {
if (onData != nullptr) {
onData(interest, const_cast<Data&>(data));
}
},
bind([]{}),
onTimeout
);
}
Actions