NFD » ndn-cxx

20150617 conference call reviewed revision 565e09af25b894d45ad5ff2e576ed2864c5371ae.
Comments are:

• DataCallback NackCallback TimeoutCallback should have const Interest& interest parameter.
  • Semantically, Interest and Data/Nack/timeout form a pair.
  • In implementation, the Interest is stored in the PIT, so there's no additional cost to pass it to the callback.
• put shouldn't require shared_ptr. Instead, it should take const Nack& and always make a copy (so that caller doesn't need to keep the Nack unchanged.

https://gist.github.com/yoursunny/2c1ce576cd23c9b8b817/b70328e239a893b5d817ff9f007794463f570435 addresses note-5 comments.

Agreed

How does the deprecated expressInterest() still work if PendingInterest and FaceImpl are both modified to only work with the new API?

Answer to note-13:

const PendingInterestId*
Face::expressInterest(const Interest& interest,
                      const OnData& onData,
                      const OnTimeout& onTimeout)
{
  return this->expressInterest(
    interest,
    [onData] (const Interest& interest, const Data& data) {
      if (onData != nullptr) {
        onData(interest, const_cast<Data&>(data));
      }
    },
    bind([]{}),
    onTimeout
  );
}