Project

General

Profile

Actions

Task #2893

closed

Simplify CommandOptions with SigningInfo

Added by Junxiao Shi almost 9 years ago. Updated over 8 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Management
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
1.50 h

Description

Replace signing options in ndn::nfd::CommandOptions with ndn::security::SigningInfo.

On CommandOptions type, provide getter/setter for SigningInfo, and mark old APIs as DEPRECATED.


Related issues 4 (0 open4 closed)

Has duplicate ndn-cxx - Task #2921: Make use of security::SigningInfo in nfd::CommandOptionsClosed

Actions
Blocked by ndn-cxx - Feature #2871: KeyChain: general signing APIClosedYingdi Yu

Actions
Blocks ndn-cxx - Task #2932: Face: simplify prefix registration APIs with SigningInfoClosedJoao Pereira07/02/2015

Actions
Blocks ndn-cxx - Task #2890: Delete deprecated KeyChain methodsAbandoned

Actions
Actions #1

Updated by Junxiao Shi almost 9 years ago

Actions #2

Updated by Junxiao Shi almost 9 years ago

  • Has duplicate Task #2921: Make use of security::SigningInfo in nfd::CommandOptions added
Actions #3

Updated by Junxiao Shi almost 9 years ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 20

Additions:

partial class CommandOptions
{
public:
  const SigningInfo&
  getSigningInfo() const;

  CommandOptions&
  setSigningInfo(const SigningInfo& signingInfo);

private:
  SigningInfo m_signingInfo;
};

Deprecated:

SigningParamsKind
getSigningParamsKind
getSigningIdentity
getSigningCertificate
setSigningDefault
setSigningIdentity
setSigningCertificate

Removed:

m_signingParamsKind
m_identity
Actions #4

Updated by Junxiao Shi almost 9 years ago

  • Blocks Task #2932: Face: simplify prefix registration APIs with SigningInfo added
Actions #5

Updated by Junxiao Shi almost 9 years ago

  • % Done changed from 20 to 70

http://gerrit.named-data.net/2149

NFD is using a deprecated method, and needs to be fixed in this issue.
https://travis-ci.org/yoursunny/ndn-cxx-breaks/builds/68030385

Actions #7

Updated by Junxiao Shi almost 9 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 70 to 100
Actions #8

Updated by Junxiao Shi almost 9 years ago

  • Description updated (diff)
  • Status changed from Closed to Resolved
  • % Done changed from 100 to 80

I'll add DEPRECATED macro after Jul 01 12:00 UTC.

This will be done as part of this issue, because it's expected that few other projects are using those APIs.

Notice is sent to ndn-lib and nfd-dev.

Actions #9

Updated by Junxiao Shi over 8 years ago

  • Blocks Task #2890: Delete deprecated KeyChain methods added
Actions #10

Updated by Junxiao Shi over 8 years ago

During 20150629 conference call, Alex approves putting DEPRECATED.

Actions #11

Updated by Junxiao Shi over 8 years ago

  • Status changed from Resolved to In Progress
Actions #12

Updated by Junxiao Shi over 8 years ago

  • Status changed from In Progress to Code review
  • % Done changed from 80 to 100
Actions #13

Updated by Junxiao Shi over 8 years ago

  • Status changed from Code review to Closed
Actions

Also available in: Atom PDF