Task #2893: Simplify CommandOptions with SigningInfo - ndn-cxx - NDN project issue tracking system

Actions

Copy link

Task #2893

closed

Simplify CommandOptions with SigningInfo

Added by Junxiao Shi over 9 years ago. Updated over 9 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Junxiao Shi

Category:

Management

Target version:

v0.4

Start date:

Due date:

% Done:

100%

Estimated time:

1.50 h

Description

Replace signing options in ndn::nfd::CommandOptions with ndn::security::SigningInfo.

On CommandOptions type, provide getter/setter for SigningInfo, and mark old APIs as DEPRECATED.

Related issues 4 (0 open — 4 closed)

Actions

Copy link

Updated by Junxiao Shi over 9 years ago

Blocked by Feature #2871: KeyChain: general signing API added

Actions

Copy link

Updated by Junxiao Shi over 9 years ago

Has duplicate Task #2921: Make use of security::SigningInfo in nfd::CommandOptions added

Actions

Copy link

Updated by Junxiao Shi over 9 years ago

Status changed from New to In Progress
% Done changed from 0 to 20

Additions:

partial class CommandOptions
{
public:
  const SigningInfo&
  getSigningInfo() const;

  CommandOptions&
  setSigningInfo(const SigningInfo& signingInfo);

private:
  SigningInfo m_signingInfo;
};

Deprecated:

SigningParamsKind
getSigningParamsKind
getSigningIdentity
getSigningCertificate
setSigningDefault
setSigningIdentity
setSigningCertificate

Removed:

m_signingParamsKind
m_identity

Actions

Copy link

Updated by Junxiao Shi over 9 years ago

Blocks Task #2932: Face: simplify prefix registration APIs with SigningInfo added

Actions

Copy link

Updated by Junxiao Shi over 9 years ago

% Done changed from 20 to 70

http://gerrit.named-data.net/2149

NFD is using a deprecated method, and needs to be fixed in this issue.
https://travis-ci.org/yoursunny/ndn-cxx-breaks/builds/68030385

Actions

Copy link

Updated by Alex Afanasyev over 9 years ago

http://gerrit.named-data.net/#/c/2151/

Actions

Copy link

Updated by Junxiao Shi over 9 years ago

Status changed from In Progress to Closed
% Done changed from 70 to 100

Actions

Copy link

Updated by Junxiao Shi over 9 years ago

Description updated (diff)
Status changed from Closed to Resolved
% Done changed from 100 to 80

I'll add DEPRECATED macro after Jul 01 12:00 UTC.

This will be done as part of this issue, because it's expected that few other projects are using those APIs.

Notice is sent to ndn-lib and nfd-dev.

Actions

Copy link