Bug #3011
closedBroadcastStrategy: strategy name is confusing
Added by Junxiao Shi over 9 years ago. Updated about 9 years ago.
100%
Description
The broadcast strategy forwards Interests to all nexthops listed in the FIB entry.
This differs from the common understanding of the term broadcast which is expected to forward Interests to all faces even if they are not in the FIB entry.
Therefore, this strategy should be renamed as multicast strategy.
Files
email.pdf (39.7 KB) email.pdf | Spyros Mastorakis, 07/07/2015 09:33 PM | ||
20150828170427-2.tgz (151 KB) 20150828170427-2.tgz | integ 2403,1 | Junxiao Shi, 08/28/2015 11:06 AM |
Updated by Spyros Mastorakis over 9 years ago
What is the target version for this bug? Should I assign it to myself and fix it?
Updated by Junxiao Shi over 9 years ago
This issue is waiting on Lixia to provide evidence that proves the confusion.
No target version will be set until the proof is in place.
Updated by Spyros Mastorakis over 9 years ago
I can provide some emails of ndnSIM users having been confused because of that. Actually, I received the last one some days before.
Updated by Junxiao Shi over 9 years ago
Please post the mailing list links, or attach PDFs to this issue. Two complaints shall be enough.
After that, we can set target version, and make a plan on how to do a backwards-compatible change.
Updated by Spyros Mastorakis over 9 years ago
This is the most recent related email I received. I will need some time to search the ndnSIM mailing list for a second one.
Updated by Junxiao Shi over 9 years ago
Reply to note-5: I'll wait for a second complaint before believe the confusion is widespread.
I want to point out that commenting out if (pitEntry->canForwardTo(*outFace))
does not turn the strategy into "pure broadcast" (ie. sending Interest to all faces even if there's no FIB nexthop record).
The strategy is still constrained among FIB nexthop records.
This modification would allow consumer retransmission Interests to go out of all faces listed in FIB nexthop records again, even if the out-record is unexpired.
In fact, "pure broadcast" is unfeasible under current strategy API, but I intend to solve this problem in #2000.
Updated by Spyros Mastorakis over 9 years ago
As we discussed in NFD call 08032015, I talked with two graduate students from the Mobility First project team during the recent FIA Project meeting at MIT. Both of them had looked our codebase and asked me why we broadcast the Interests.
Updated by Junxiao Shi over 9 years ago
- Assignee set to Junxiao Shi
- Target version set to v0.4
note-5 and note-7 give sufficient evidence to proceed with this issue.
I'll design the transition plan.
Updated by Junxiao Shi over 9 years ago
- Status changed from New to In Progress
Design:
- NFD code changes:
* Rename `BroadcastStrategy` class to `MulticastStrategy`, and change StrategyName to `ndn:/localhost/nfd/strategy/multicast/%FD%01`.
* Update all unit test cases to refer to `MulticastStrategy`.
* Create `BroadcastStrategy` class that inherits from `MulticastStrategy`, and overrides StrategyName to `ndn:/localhost/nfd/strategy/broadcast/%FD%01`.
- Update NFD Developer Guide to refer to "multicast strategy".
- Update IntegrationTests to use
ndn:/localhost/nfd/strategy/multicast
. - Send notification to nfd-dev and operators mailing lists.
- Delete
BroadcastStrategy
class at next release.
Updated by Junxiao Shi over 9 years ago
20150810 conference call approves the design in note-9.
Updated by Junxiao Shi over 9 years ago
- % Done changed from 0 to 20
NFD code changes: http://gerrit.named-data.net/2366
Updated by Junxiao Shi over 9 years ago
Reviewer has pointed out that commit:1d470df0da0467dae7888c5474eea134c0a8a533 is missing updates in "nfd.conf.sample.in" and "documentation that references broadcast strategy".
I have identified the following places in NFD repository that references "broadcast":
- daemon/fw/broadcast-strategy.hpp and its implementation and test suite: intentional, for backwards compatibility
- nfd.conf.sample.in and daemon/mgmt/tables-config-section.cpp: should be updated
- tools/ndn-autoconfig/multicast-discovery.cpp: should be updated
- docs/manpages/nfdc.rst: should be updated
- docs/RELEASE_NOTES.rst: do not update, to preserve history
Updated by Junxiao Shi over 9 years ago
- % Done changed from 20 to 40
devguide updated: nfd-docs:commit:d3a11ed2607a7cf2d7b8aeafcd1c28a09ddfbc70
Updated by Junxiao Shi about 9 years ago
- % Done changed from 40 to 60
integ Change: http://gerrit.named-data.net/2403
Updated by Alex Afanasyev about 9 years ago
I'm getting error (did you push just as a draft?)
Updated by Junxiao Shi about 9 years ago
- File 20150828170427-2.tgz 20150828170427-2.tgz added
Reply to note-15: yes, it's a draft which will be published when integ is passing.
Updated by Junxiao Shi about 9 years ago
- % Done changed from 60 to 80
Updated by Junxiao Shi about 9 years ago
At 20150903 conference call, Alex confirms BroadcastStrategy
can be removed before next release.
Updated by Junxiao Shi about 9 years ago
http://gerrit.named-data.net/2444 deletes BroadcastStrategy
.
Updated by Junxiao Shi about 9 years ago
- Status changed from In Progress to Code review
- % Done changed from 80 to 100
Updated by Junxiao Shi about 9 years ago
- Blocks Task #3206: Delete deprecated BroadcastStrategy added
Updated by Junxiao Shi about 9 years ago
- Status changed from Code review to Closed
The removal is split to #3206.