Project

General

Profile

Actions

Bug #3643

closed

Bug #3554: SegmentFetcher restarts from segment0 upon Nack

Add installation of openssl into build scripts

Added by Muktadir Chowdhury over 8 years ago. Updated over 8 years ago.

Status:
Closed
Priority:
Normal
Category:
Build
Target version:
Start date:
06/07/2016
Due date:
% Done:

100%

Estimated time:
0.50 h

Description

ndn-cxx should not depend on openssl. But the openssl header file was not removed from the codebase. So in one of the machines, where openssl is not installed, ndn-cxx was not building: http://jenkins.named-data.net/job/ndn-cxx/3477/OS=OSX-10.11/console.

Actions #1

Updated by Muktadir Chowdhury over 8 years ago

  • Status changed from New to Code review
  • % Done changed from 0 to 100
Actions #2

Updated by Muktadir Chowdhury over 8 years ago

  • Subject changed from Remove openssl.hpp to Remove unused openssl.hpp
  • Assignee set to Muktadir Chowdhury
Actions #4

Updated by Alex Afanasyev over 8 years ago

I will reject this. Please rebase your code on top of the latest commit in the master branch, as this issue has been already addressed.

openssl.hpp is only temporary not needed (will be needed after we merge the pending security branch)

Actions #5

Updated by Alex Afanasyev over 8 years ago

  • Status changed from Code review to Rejected
Actions #6

Updated by Junxiao Shi over 8 years ago

Please rebase your code on top of the latest commit in the master branch, as this issue has been already addressed.

Doesn't seem so.

ndn-cxx Build 3478 is a commit on top of the latest commit.

It's failing on OSX 10.11 with error:

+ brew link --force openssl
Error: No such keg: /usr/local/Cellar/openssl

Also, if OpenSSL is necessary, it should be listed as a dependency in docs/INSTALL.rst.

Actions #7

Updated by Alex Afanasyev over 8 years ago

  • Subject changed from Remove unused openssl.hpp to Add installation of openssl into build scripts
  • Category set to Build
  • Status changed from Rejected to Code review
  • Assignee changed from Muktadir Chowdhury to Alex Afanasyev
  • Target version set to v0.4

I'm reopening a modified version of this issue. There are a few things that were forgotten:

  • actual installation of openssl package with homebrew
  • installation of libssl-dev package on ubuntu
  • the same dependency installation in NFD build scripts.
Actions #9

Updated by Junxiao Shi over 8 years ago

  • Status changed from Code review to Closed
Actions

Also available in: Atom PDF