Bug #3643
closed
Bug #3554: SegmentFetcher restarts from segment0 upon Nack
Add installation of openssl into build scripts
100%
Description
ndn-cxx should not depend on openssl. But the openssl header file was not removed from the codebase. So in one of the machines, where openssl is not installed, ndn-cxx was not building: http://jenkins.named-data.net/job/ndn-cxx/3477/OS=OSX-10.11/console.
Updated by Muktadir Chowdhury almost 8 years ago
- Status changed from New to Code review
- % Done changed from 0 to 100
Updated by Muktadir Chowdhury almost 8 years ago
- Subject changed from Remove openssl.hpp to Remove unused openssl.hpp
- Assignee set to Muktadir Chowdhury
Updated by Muktadir Chowdhury almost 8 years ago
Like Bug 3554 patch (http://redmine.named-data.net/issues/3554), this patch is also failing on OSX 10.11 : http://jenkins.named-data.net/job/ndn-cxx/3480/OS=OSX-10.11/console
Updated by Alex Afanasyev almost 8 years ago
I will reject this. Please rebase your code on top of the latest commit in the master branch, as this issue has been already addressed.
openssl.hpp is only temporary not needed (will be needed after we merge the pending security branch)
Updated by Alex Afanasyev almost 8 years ago
- Status changed from Code review to Rejected
Updated by Junxiao Shi almost 8 years ago
Please rebase your code on top of the latest commit in the master branch, as this issue has been already addressed.
Doesn't seem so.
ndn-cxx Build 3478 is a commit on top of the latest commit.
It's failing on OSX 10.11 with error:
+ brew link --force openssl
Error: No such keg: /usr/local/Cellar/openssl
Also, if OpenSSL is necessary, it should be listed as a dependency in docs/INSTALL.rst.
Updated by Alex Afanasyev almost 8 years ago
- Subject changed from Remove unused openssl.hpp to Add installation of openssl into build scripts
- Category set to Build
- Status changed from Rejected to Code review
- Assignee changed from Muktadir Chowdhury to Alex Afanasyev
- Target version set to v0.4
I'm reopening a modified version of this issue. There are a few things that were forgotten:
- actual installation of openssl package with homebrew
- installation of libssl-dev package on ubuntu
- the same dependency installation in NFD build scripts.
Updated by Alex Afanasyev almost 8 years ago
Updated by Junxiao Shi over 7 years ago
- Status changed from Code review to Closed