Project

General

Profile

Feature #3866

nfdc route commands

Added by Junxiao Shi over 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Tools
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
9.00 h

Description

In nfdc, implement these commands:

fib list
route list [[nexthop] <id|uri>] [origin <origin>]
route show [prefix] <prefix>
route add [prefix] <prefix> [nexthop] <id|uri> [cost <cost>] [origin <origin>] [no-inherit] [capture] [expires <millis>]
route remove [prefix] <prefix> [nexthop] <id|uri> [origin <origin>]

New commands should have #2542 output format; fix any IntegrationTests issues caused by fib list and route list format change.
Deprecate register, unregister, add-nexthop, and remove-nexthop commands, but do not change their output format.


Related issues

Related to NFD - Feature #2542: Redesign nfdc combining nfdc and nfd-statusClosed

Actions

History

#1

Updated by Junxiao Shi over 3 years ago

  • Related to Feature #2542: Redesign nfdc combining nfdc and nfd-status added
#2

Updated by Alex Afanasyev about 3 years ago

Suggestion for nfdc route add: the output of "successful" registration should state that the command accepted. Our protocol does not guarantee to actually "succeed" the registration.

#3

Updated by Junxiao Shi about 3 years ago

  • Status changed from New to In Progress
  • Assignee set to Junxiao Shi
  • % Done changed from 0 to 30
#4

Updated by Junxiao Shi about 3 years ago

https://gerrit.named-data.net/3723 nfdc route remove

A difference from route add is: when a FaceUri matches multiple faces, this command attempts to remove routes from all matching faces. I feel in this case it's unnecessary to print disambiguation and require exact FaceId, as the operator's intention is most likely "remove all".

Independent from the above, nfdc route remove would succeed even if the route does not exist previously. This behavior is same as old nfdc unregister, and I don't intend to change it in any way.

#5

Updated by Junxiao Shi about 3 years ago

  • % Done changed from 30 to 40

https://gerrit.named-data.net/3723 patchset2 refactors MockNfdMgmtFixture to allow a tested unit to send multiple command Interests together. Old APIs are deprecated.
Separate two commits will convert other test suites to use new MockNfdMgmtFixture APIs and delete old APIs, as well as performing the same refactoring for datasets.

#6

Updated by Junxiao Shi about 3 years ago

  • % Done changed from 40 to 50

https://gerrit.named-data.net/3749 converts nfdc test suites to use new MockNfdMgmtFixture APIs which require specific command Interest to be passed in order to send a response.

#7

Updated by Junxiao Shi about 3 years ago

  • % Done changed from 50 to 70

https://gerrit.named-data.net/3750 nfdc route list and nfdc route show

#8

Updated by Junxiao Shi about 3 years ago

  • Status changed from In Progress to Code review
  • % Done changed from 70 to 100

https://gerrit.named-data.net/3756 deprecates nfdc register and nfdc unregister and nfdc add-nexthop and nfdc remove-nexthop.

#9

Updated by Davide Pesavento about 3 years ago

  • Status changed from Code review to Closed

Also available in: Atom PDF