Task #3870
closed
Use SIGQUIT instead of SIGINT
Added by Ashlesh Gawande almost 8 years ago.
Updated about 7 years ago.
Description
Use SIGQUIT (control+ \) instead of SIGINT because control+c is used to kill programs such as ndnpingserver
- Related to Task #3672: Mini-NDN must exit gracefully if NLSR is not coverged added
- Description updated (diff)
- Assignee changed from Ashlesh Gawande to Damian Coomes
Check if Control-C kills NFD running on the node in addition to ndnpingserver or something else running in foreground before implementing this.
- Status changed from New to In Progress
- Status changed from In Progress to Code review
- % Done changed from 0 to 90
Damian, turns out the NFD receiving sigint of parent is solved by using setsid when running nfd.
Can you test this change:
https://gerrit.named-data.net/#/c/4259/
Especially test that NFD is no longer killed.
Also run the failure convergence test and make sure NFD is killed and brought up correctly.
Also, if you have time - add some documents for this. Thanks.
Nevermind, I will push to your old change - I forgot about that.
Yeah, it looks like it is working properly. I ran minindn and checked that nfd is not killed after a SIGINT is sent to stop ndnping. Convergence and failed convergence tests both work. NFD is killed on the node that is brought down during the failed convergence test and then is restarted.
- Status changed from Code review to Closed
- % Done changed from 90 to 100
- Target version set to v0.4.0
Also available in: Atom
PDF