Project

General

Profile

Task #3924

Reimplement util::Sha256 without cryptopp

Added by Alex Afanasyev over 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Category:
Utils
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:

Description

Current implementation is based on CryptoPP, which should be replaced with security::transform::digestFilter.


Related issues

Blocks ndn-cxx - Task #3886: Remove util::Digest class templateClosedDavide Pesavento

Actions
Blocks ndn-cxx - Task #3946: Get rid of cryptopp dependencyClosedDavide Pesavento

Actions
#1

Updated by Davide Pesavento over 3 years ago

  • Description updated (diff)
#2

Updated by Junxiao Shi over 3 years ago

This is impossible as a non-breaking change, because the template parameter comes from CryptoPP.

#3

Updated by Davide Pesavento over 3 years ago

  • Subject changed from Refactor util::Digest to use transform::digestFilter to Refactor util::Sha256 to use transform::digestFilter
  • Assignee set to Davide Pesavento
#4

Updated by Davide Pesavento over 3 years ago

  • Blocks Task #3886: Remove util::Digest class template added
#5

Updated by Davide Pesavento over 3 years ago

  • Blocks Task #3946: Get rid of cryptopp dependency added
#6

Updated by Davide Pesavento about 3 years ago

See https://redmine.named-data.net/issues/3886#note-9 for some more background on the decision.

#7

Updated by Davide Pesavento about 3 years ago

  • Status changed from New to In Progress

There does not seem to be a clean way to implement Sha256 using the security::transform framework. The former is inherently incremental, whereas a transform chain expects all its input to be available in one go and when the input is exhausted the digest gets finalized.

Any ideas?

#8

Updated by Davide Pesavento about 3 years ago

  • Subject changed from Refactor util::Sha256 to use transform::digestFilter to Reimplement util::Sha256 without cryptopp
  • Status changed from In Progress to Code review
  • % Done changed from 0 to 100
#9

Updated by Davide Pesavento about 3 years ago

  • Status changed from Code review to Closed

Also available in: Atom PDF