Project

General

Profile

Feature #3956

faces/create response: LocalUri field

Added by Junxiao Shi over 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Management
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
3.00 h

Description

In FaceMgmt, faces/create command response should set the LocalUri field, because this information is not otherwise available to the management client especially on a system with multiple network interfaces.

This issues involves:

  • protocol update
  • in ndn::nfd::FaceCreateCommand, require LocalUri in response
  • in FaceManager, include LocalUri in response
  • in nfdc face create, display LocalUri

Related issues

Blocked by NFD - Feature #3864: nfdc face commandsClosedJunxiao Shi

Actions
#1

Updated by Junxiao Shi over 3 years ago

#2

Updated by Junxiao Shi over 3 years ago

  • Status changed from New to In Progress
  • Assignee set to Junxiao Shi

FaceMgmt r68 specifies that both Uri and LocalUri are required in FaceCreateCommand response.

Implementation plan:

  1. set Uri and LocalUri as optional (otherwise NFD will break)
  2. change both NFD-mgmt and nfdc
  3. set Uri and LocalUri as required
#3

Updated by Junxiao Shi over 3 years ago

https://gerrit.named-data.net/3850 is step1 of note-2 plan.

#4

Updated by Junxiao Shi over 3 years ago

  • % Done changed from 0 to 50

https://gerrit.named-data.net/3864 is step2 of note-2 plan.

Effect:

vagrant@m0212:~/NFD$ nfdc face create tcp4://hobo
face-created id=262 local=tcp4://10.0.2.15:60133 remote=tcp4://128.196.203.36:6363 persistency=persistent
vagrant@m0212:~/NFD$ nfdc face create tcp4://hobo
face-exists id=262 local=tcp4://10.0.2.15:60133 remote=tcp4://128.196.203.36:6363 persistency=persistent
vagrant@m0212:~/NFD$ nfdc face create tcp4://spurs.cs.ucla.edu
face-created id=265 local=tcp4://10.0.2.15:47524 remote=tcp4://131.179.196.46:6363 persistency=persistent

There is currently no test coverage on management side, because face-manager-create-face.t.cpp is very messy. I plan to refactor that with NfdManagerCommonFixture in #3377.

#5

Updated by Junxiao Shi over 3 years ago

  • % Done changed from 50 to 80

https://gerrit.named-data.net/3869 is step3 of note-2 plan.

#6

Updated by Junxiao Shi over 3 years ago

  • Status changed from In Progress to Code review
  • % Done changed from 80 to 100

https://gerrit.named-data.net/3875 fixes a previous oversight: Flags field should be included in mocked faces/create response.

#7

Updated by Junxiao Shi about 3 years ago

  • Status changed from Code review to Closed

Also available in: Atom PDF