Feature #3956
closed
faces/create response: LocalUri field
100%
Description
In FaceMgmt, faces/create command response should set the LocalUri field, because this information is not otherwise available to the management client especially on a system with multiple network interfaces.
This issues involves:
- protocol update
- in
ndn::nfd::FaceCreateCommand, require LocalUri in response - in
FaceManager, include LocalUri in response - in
nfdc face create, display LocalUri
Updated by Junxiao Shi about 7 years ago
- Blocked by Feature #3864: nfdc face commands added
Updated by Junxiao Shi about 7 years ago
- Status changed from New to In Progress
- Assignee set to Junxiao Shi
FaceMgmt r68 specifies that both Uri and LocalUri are required in FaceCreateCommand response.
Implementation plan:
- set Uri and LocalUri as optional (otherwise NFD will break)
- change both NFD-mgmt and nfdc
- set Uri and LocalUri as required
Updated by Junxiao Shi about 7 years ago
https://gerrit.named-data.net/3850 is step1 of note-2 plan.
Updated by Junxiao Shi almost 7 years ago
- % Done changed from 0 to 50
https://gerrit.named-data.net/3864 is step2 of note-2 plan.
Effect:
vagrant@m0212:~/NFD$ nfdc face create tcp4://hobo
face-created id=262 local=tcp4://10.0.2.15:60133 remote=tcp4://128.196.203.36:6363 persistency=persistent
vagrant@m0212:~/NFD$ nfdc face create tcp4://hobo
face-exists id=262 local=tcp4://10.0.2.15:60133 remote=tcp4://128.196.203.36:6363 persistency=persistent
vagrant@m0212:~/NFD$ nfdc face create tcp4://spurs.cs.ucla.edu
face-created id=265 local=tcp4://10.0.2.15:47524 remote=tcp4://131.179.196.46:6363 persistency=persistent
There is currently no test coverage on management side, because face-manager-create-face.t.cpp is very messy. I plan to refactor that with NfdManagerCommonFixture in #3377.
Updated by Junxiao Shi almost 7 years ago
- % Done changed from 50 to 80
https://gerrit.named-data.net/3869 is step3 of note-2 plan.
Updated by Junxiao Shi almost 7 years ago
- Status changed from In Progress to Code review
- % Done changed from 80 to 100
https://gerrit.named-data.net/3875 fixes a previous oversight: Flags field should be included in mocked faces/create response.
Updated by Junxiao Shi almost 7 years ago
- Status changed from Code review to Closed