Project

General

Profile

Actions

Feature #4027

closed

FaceUri: canonize dev scheme

Added by Junxiao Shi over 7 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Utils
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
3.00 h

Description

In FaceUri, implement a canonize provider for dev scheme.

Actions #1

Updated by Junxiao Shi over 7 years ago

  • Blocked by Feature #3353: NetworkMonitor: emit fine-grained signals when the state of a network interface changes added
Actions #2

Updated by Junxiao Shi over 7 years ago

  • Status changed from New to In Progress
  • Assignee set to Junxiao Shi

https://gerrit.named-data.net/3811 determines a FaceUri of dev scheme as canonical if the network interface exists.
But it's implemented only in canonize; I don't have a good way to implement isCanonical because it is a synchronous API and cannot use NetworkMonitor.

patchset1 isn't working due to #3353-28 bug.

Actions #3

Updated by Junxiao Shi over 7 years ago

  • Blocked by deleted (Feature #3353: NetworkMonitor: emit fine-grained signals when the state of a network interface changes)
Actions #4

Updated by Junxiao Shi over 7 years ago

  • Status changed from In Progress to Code review
  • % Done changed from 0 to 100

Due the difficulty and inefficiency with NetworkMonitor, https://gerrit.named-data.net/3811 patchset2 treats a FaceUri as canonical if the form looks right (no port or path), but does not test whether the network interface exists. This is consistent with udp4 scheme which doesn't check whether an IP address is routable.

Actions #5

Updated by Davide Pesavento over 7 years ago

Junxiao Shi wrote:

Due the difficulty and inefficiency with NetworkMonitor, https://gerrit.named-data.net/3811 patchset2 treats a FaceUri as canonical if the form looks right (no port or path), but does not test whether the network interface exists. This is consistent with udp4 scheme which doesn't check whether an IP address is routable.

Yep, I agree.

Actions #6

Updated by Alex Afanasyev over 7 years ago

I also agree.

Actions #7

Updated by Davide Pesavento over 7 years ago

  • Status changed from Code review to Closed
Actions

Also available in: Atom PDF