Task #4110
closedReplace RoutingTableEntry with a tuple
0%
Description
Currently, the RoutingTable stores entries as a class, RoutingTableEntry. All this does is provide getters and setters, and define equality. A tuple provides equality comparison by element-wise comparison, which is exactly how RoutingTableEntry currently implements it.
Separating this data container into a class suggests that it has some kind of behavior or state modification. However, it is only a data container, so a POD is more appropriate. A tuple is better than a struct in this situation because C++11 provides a built-in operator== for tuples, but not structs.
Updated by Nicholas Gordon almost 7 years ago
- Target version changed from v0.4.0 to v0.5.0
Updated by Nicholas Gordon almost 7 years ago
- Target version changed from v0.5.0 to Minor release 0.4.1
Updated by Ashlesh Gawande over 6 years ago
- Target version changed from Minor release 0.4.1 to v0.5.0
Updated by Saurab Dulal over 5 years ago
- Target version changed from v0.5.0 to Minor release v0.5.1
Updated by Saurab Dulal over 5 years ago
- Target version changed from Minor release v0.5.1 to v0.6.0
Updated by Saurab Dulal almost 4 years ago
- Target version changed from v0.6.0 to Minor Release v0.6.1
Updated by Junxiao Shi over 1 year ago
- Status changed from New to Closed
This task is no longer appropriate because commit:0421bc6bcd239f5bd422cd2ad8087368cdc5535f introduced behaviors (wireEncode
and wireDecode
) into RoutingTableEntry
class.