Project

General

Profile

Actions

Task #4137

closed

Make LSA types const correct

Added by Nicholas Gordon over 7 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Ryan Wickman
Target version:
Start date:
06/16/2017
Due date:
% Done:

0%

Estimated time:

Description

Currently the LSA types mix logical const and non-const in their usage. This is a problem, because it makes reasoning about an LSA much harder, and reduces code hygeine. The LSA types should be const correct so that operator== can be implemented correctly, as well as improving design clarity.

This will probably require a rewrite of the LSA types, as the problematic underlying data structures differ from one to the next, and the ways they are modified are inconsistent.


Related issues 1 (0 open1 closed)

Blocks NLSR - Feature #4094: Implement operator== for LSA typesClosedJunxiao Shi06/16/2017

Actions
Actions #1

Updated by Nicholas Gordon almost 7 years ago

  • Target version changed from v0.5.0 to Minor release 0.4.1
Actions #2

Updated by Ashlesh Gawande over 6 years ago

  • Target version changed from Minor release 0.4.1 to v0.5.0
Actions #3

Updated by Ryan Wickman over 6 years ago

  • Assignee set to Ryan Wickman
Actions #4

Updated by Ryan Wickman over 6 years ago

  • Status changed from New to In Progress
Actions #5

Updated by Ryan Wickman over 6 years ago

  • Status changed from In Progress to Code review
Actions #6

Updated by Ryan Wickman over 6 years ago

  • Status changed from Code review to Closed
Actions #7

Updated by Junxiao Shi about 1 year ago

  • Parent task deleted (#4094)
Actions #8

Updated by Junxiao Shi about 1 year ago

Actions

Also available in: Atom PDF