Feature #4094: Implement operator== for LSA types - NLSR - NDN project issue tracking system

Actions

Copy link

Feature #4094

closed

Implement operator== for LSA types

Added by Nicholas Gordon about 8 years ago. Updated over 1 year ago.

Status:

Closed

Priority:

Normal

Assignee:

Junxiao Shi

Target version:

Start date:

06/16/2017

Due date:

% Done:

100%

Estimated time:

1.00 h

Description

Once #2962 is closed, the {Name, Adjacency, Coordinate}Lsa classes each will have ways to compare them for equality. The idiomatic way to compare two complex objects is to define that behavior in operator==.

This also simplifies testing procedures, and makes source more intuitive.

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Nicholas Gordon about 8 years ago

I attempted to implement this, but operator==() should always be const. However, many of the participating methods for the data structures of the LSAs are not const, so they require constification, first. At some points this requires many steps of spot fixes, and in some places simple constification is not possible due to logical inconsistencies.

Achieving this will require more careful thought and possibly redesign of the LSA classes and their data structures.

Actions

Copy link

Updated by Nicholas Gordon over 7 years ago

Target version changed from v0.4.0 to v0.5.0

Actions

Copy link

Updated by Nicholas Gordon over 7 years ago

Target version changed from v0.5.0 to Minor release 0.4.1

Actions

Copy link

Updated by Ashlesh Gawande over 7 years ago

Target version changed from Minor release 0.4.1 to v0.5.0

Actions

Copy link

Updated by Ryan Wickman about 7 years ago

Status changed from New to In Progress
Assignee set to Ryan Wickman

Actions

Copy link

Updated by Ryan Wickman about 7 years ago

Status changed from In Progress to Code review

Actions

Copy link

Updated by Saurab Dulal over 6 years ago

Target version changed from v0.5.0 to Minor release v0.5.1

Actions

Copy link

Updated by Saurab Dulal about 6 years ago

Target version changed from Minor release v0.5.1 to v0.6.0

Actions

Copy link

Updated by Saurab Dulal over 4 years ago

Target version changed from v0.6.0 to Minor Release v0.6.1

Actions

Copy link

#10

Updated by Junxiao Shi almost 2 years ago

Tracker changed from Task to Feature
Assignee changed from Ryan Wickman to Junxiao Shi
Target version deleted (~~Minor Release v0.6.1~~ )

https://gerrit.named-data.net/c/NLSR/+/7146 NameLsa

Actions

Copy link

#11

Updated by Junxiao Shi almost 2 years ago

Subtask deleted (~~#4137~~)

Actions

Copy link

#12

Updated by Junxiao Shi almost 2 years ago

Blocked by Task #4137: Make LSA types const correct added

Actions

Copy link

#13

Updated by Junxiao Shi almost 2 years ago

% Done changed from 100 to 20

Actions

Copy link

#14

Updated by Junxiao Shi almost 2 years ago

https://gerrit.named-data.net/c/NLSR/+/7147 fixes NamePrefixList::operator== so that it compares names only, which is the behavior prescribed in a unit test comment.
This patch also simplifies the implementation of NamePrefixList type.
NamePrefixList type is now a fully sorted container, and the sort() method is deleted.

Actions

Copy link

#15