Task #4094: Implement operator== for LSA types - NLSR - NDN project issue tracking system

Task #4094

Implement operator== for LSA types

Added by Nicholas Gordon almost 4 years ago. Updated 2 months ago.

Status:

Code review

Priority:

Normal

Assignee:

Ryan Wickman

Target version:

Minor Release v0.6.1

Start date:

06/16/2017

Due date:

% Done:

100%

Estimated time:

1.00 h

Description

Once #2962 is closed, the {Name, Adjacency, Coordinate}Lsa classes each will have ways to compare them for equality. The idiomatic way to compare two complex objects is to define that behavior in operator==.

This also simplifies testing procedures, and makes source more intuitive.

Subtasks

Updated by Nicholas Gordon over 3 years ago

I attempted to implement this, but operator==() should always be const. However, many of the participating methods for the data structures of the LSAs are not const, so they require constification, first. At some points this requires many steps of spot fixes, and in some places simple constification is not possible due to logical inconsistencies.

Achieving this will require more careful thought and possibly redesign of the LSA classes and their data structures.