Feature #4094
closed
Implement operator== for LSA types
100%
Description
Once #2962 is closed, the {Name, Adjacency, Coordinate}Lsa classes each will have ways to compare them for equality. The idiomatic way to compare two complex objects is to define that behavior in operator==.
This also simplifies testing procedures, and makes source more intuitive.
Updated by Nicholas Gordon almost 7 years ago
I attempted to implement this, but operator==() should always be const. However, many of the participating methods for the data structures of the LSAs are not const, so they require constification, first. At some points this requires many steps of spot fixes, and in some places simple constification is not possible due to logical inconsistencies.
Achieving this will require more careful thought and possibly redesign of the LSA classes and their data structures.
Updated by Nicholas Gordon over 6 years ago
- Target version changed from v0.4.0 to v0.5.0
Updated by Nicholas Gordon over 6 years ago
- Target version changed from v0.5.0 to Minor release 0.4.1
Updated by Ashlesh Gawande about 6 years ago
- Target version changed from Minor release 0.4.1 to v0.5.0
Updated by Ryan Wickman almost 6 years ago
- Status changed from New to In Progress
- Assignee set to Ryan Wickman
Updated by Ryan Wickman almost 6 years ago
- Status changed from In Progress to Code review
Updated by Saurab Dulal about 5 years ago
- Target version changed from v0.5.0 to Minor release v0.5.1
Updated by Saurab Dulal almost 5 years ago
- Target version changed from Minor release v0.5.1 to v0.6.0
Updated by Saurab Dulal over 3 years ago
- Target version changed from v0.6.0 to Minor Release v0.6.1
Updated by Junxiao Shi 8 months ago
- Tracker changed from Task to Feature
- Assignee changed from Ryan Wickman to Junxiao Shi
- Target version deleted (
Minor Release v0.6.1)
Updated by Junxiao Shi 8 months ago
- Blocked by Task #4137: Make LSA types const correct added
Updated by Junxiao Shi 8 months ago
https://gerrit.named-data.net/c/NLSR/+/7147 fixes NamePrefixList::operator== so that it compares names only, which is the behavior prescribed in a unit test comment.
This patch also simplifies the implementation of NamePrefixList type.
NamePrefixList type is now a fully sorted container, and the sort() method is deleted.
Updated by Junxiao Shi 8 months ago
https://gerrit.named-data.net/c/NLSR/+/7167 splits test-lsa.cpp into three test suites, in preparation of further cleans in LSA test suites.
Updated by Junxiao Shi 4 months ago
- % Done changed from 20 to 50
Updated by Junxiao Shi 4 months ago
- % Done changed from 50 to 80
https://gerrit.named-data.net/c/NLSR/+/7297 CoordinateLsa
Updated by Junxiao Shi 4 months ago
- % Done changed from 80 to 100
https://gerrit.named-data.net/c/NLSR/+/7298 final cleanups moved to #5308