Project

General

Profile

Task #4094

Implement operator== for LSA types

Added by Nicholas Gordon almost 4 years ago. Updated 2 months ago.

Status:
Code review
Priority:
Normal
Assignee:
Target version:
Start date:
06/16/2017
Due date:
% Done:

100%

Estimated time:
1.00 h

Description

Once #2962 is closed, the {Name, Adjacency, Coordinate}Lsa classes each will have ways to compare them for equality. The idiomatic way to compare two complex objects is to define that behavior in operator==.

This also simplifies testing procedures, and makes source more intuitive.


Subtasks

Task #4137: Make LSA types const correctClosedRyan Wickman06/16/2017

Actions
#1

Updated by Nicholas Gordon over 3 years ago

I attempted to implement this, but operator==() should always be const. However, many of the participating methods for the data structures of the LSAs are not const, so they require constification, first. At some points this requires many steps of spot fixes, and in some places simple constification is not possible due to logical inconsistencies.

Achieving this will require more careful thought and possibly redesign of the LSA classes and their data structures.

#2

Updated by Nicholas Gordon over 3 years ago

  • Target version changed from v0.4.0 to v0.5.0
#3

Updated by Nicholas Gordon about 3 years ago

  • Target version changed from v0.5.0 to Minor release 0.4.1
#4

Updated by Ashlesh Gawande about 3 years ago

  • Target version changed from Minor release 0.4.1 to v0.5.0
#5

Updated by Ryan Wickman almost 3 years ago

  • Status changed from New to In Progress
  • Assignee set to Ryan Wickman
#6

Updated by Ryan Wickman almost 3 years ago

  • Status changed from In Progress to Code review
#7

Updated by Saurab Dulal about 2 years ago

  • Target version changed from v0.5.0 to Minor release v0.5.1
#8

Updated by Saurab Dulal over 1 year ago

  • Target version changed from Minor release v0.5.1 to v0.6.0
#9

Updated by Saurab Dulal 2 months ago

  • Target version changed from v0.6.0 to Minor Release v0.6.1

Also available in: Atom PDF