Bug #4236
closed
Jenkins does not trigger a build on rebased patchset
100%
Description
Steps to reproduce:
- Post a patchset on Gerrit. Wait for Jenkins build to complete successfully.
- Find (or create) another Change. Wait for Jenkins build to complete successfully.
- Rebase the patchset in step1 onto the Change in step2, without changing another else.
Expected: Jenkins triggers a build on rebased patchset.
Actual: Jenkins does not trigger a build.
Updated by Junxiao Shi over 7 years ago
- Assignee set to Eric Newberry
- Priority changed from Normal to High
This problem has been occurring since Feb 2016, around the time when Gerrit was configured to preserve Code-Review votes on rebased patchsets. Verified votes aren't perserved, but builds aren't triggered as expected.
This problem severely slows down NFD development. It also seems to affect ndn-cxx and NLSR.
Updated by Eric Newberry over 7 years ago
- Status changed from New to In Progress
Updated by Eric Newberry over 7 years ago
I've set NFD to also start a build on "ref update". Let's see what that does...
Updated by Eric Newberry over 7 years ago
Eric Newberry wrote:
I've set NFD to also start a build on "ref update". Let's see what that does...
It doesn't look like that's what we're looking for, as it appeared to cause unnecessary rebuilds. I've removed "ref update" from NFD and I'm still investigating this issue.
Updated by Eric Newberry over 7 years ago
- Status changed from In Progress to Feedback
I've set builds to start for NFD on "trivial rebuilds", where there were no conflicts rebasing. This seems like what we're looking for...
Updated by Eric Newberry over 7 years ago
Eric Newberry wrote:
I've set builds to start for NFD on "trivial rebuilds", where there were no conflicts rebasing. This seems like what we're looking for...
It looks like ndn-cxx and NLSR already have their settings set this way.
Updated by
Updated by Eric Newberry over 7 years ago
Davide Pesavento wrote:
What about ndn-tools?
ndn-tools is the same as ndn-cxx and NLSR.
Updated by Eric Newberry over 7 years ago
I looked through all of the automatic emails I received about builds not starting since the beginning of July. It looks like all the affected patchsets were for NFD. I have yet to receive an email since I changed the trivial rebuilds setting, so perhaps this fixed it?
Updated by Eric Newberry over 7 years ago
- Status changed from Feedback to Closed
- % Done changed from 0 to 100
I still have yet to receive another automated email indicating that a build didn't start, so I'm going to assume that the issue is fixed and close it. I'll reopen it later if necessary.
Updated by Junxiao Shi over 7 years ago
I still have yet to receive another automated email indicating that a build didn't start
The script was no longer running due to unavailability of avenir. I have no plan of recovered it, even after avenir comes back.
close it. I'll reopen it later if necessary.
That's fine.