Project

General

Profile

Actions

Bug #4524

closed

validator_config::Checker should enforce sig-type check

Added by Anonymous over 6 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Category:
Security
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:

Description

When validator_config::Checker::createCustomizedChecker is reading the config file "checker" section, it ignores the "sig-type":
https://github.com/named-data/ndn-cxx/blob/5dc7560d5dbcdf2588796f315f15c9704a2a314f/ndn-cxx/security/validator-config/checker.cpp#L170

But the Validator Configuration File spec say that the packet is required to have a signature of the specified sig-type:
https://named-data.net/doc/ndn-cxx/current/tutorials/security-validator-config.html#customized-checker

The task is to implement this check in ndn-cxx.


Related issues 1 (1 open0 closed)

Related to ndn-cxx - Feature #5148: ValidatorConfig: multiple sig-type restrictions in a single checkerNew

Actions
Actions #1

Updated by Davide Pesavento over 6 years ago

  • Category set to Security
  • Start date deleted (03/01/2018)
Actions #2

Updated by Alex Afanasyev over 4 years ago

  • Tags set to security
Actions #3

Updated by Davide Pesavento about 4 years ago

  • Tags changed from security to security, needs-discussion
Actions #4

Updated by Junxiao Shi over 3 years ago

  • Tags changed from security, needs-discussion to security
  • Tracker changed from Task to Bug
  • Assignee set to Junxiao Shi
  • Target version set to 0.8.0

20210212 NFD call decides to make sig-type an optional field, and indicate that the implementation ignores it.

Actions #5

Updated by Junxiao Shi over 3 years ago

  • Status changed from New to In Progress
  • Estimated time set to 1.50 h
Actions #6

Updated by Junxiao Shi over 3 years ago

  • % Done changed from 0 to 50
Actions #7

Updated by Junxiao Shi over 3 years ago

  • Related to Feature #5148: ValidatorConfig: multiple sig-type restrictions in a single checker added
Actions #8

Updated by Junxiao Shi over 3 years ago

  • Tags changed from security to security, ValidatorConfig
Actions #9

Updated by Junxiao Shi over 3 years ago

  • Assignee deleted (Junxiao Shi)

Due to fundamental disagreement on how to proceed with this change, I will unassign myself and abandon the pending commit.

Actions #10

Updated by Davide Pesavento over 3 years ago

  • Status changed from In Progress to New
  • % Done changed from 50 to 0
Actions #11

Updated by Alex Afanasyev over 3 years ago

  • Subject changed from Should v2::Checker ignore the sig-type? to v2::Checker should enforce sig-type check
Actions #12

Updated by Alex Afanasyev over 3 years ago

  • Assignee set to Alex Afanasyev
  • % Done changed from 0 to 90
  • Estimated time deleted (1.50 h)
Actions #13

Updated by Davide Pesavento over 3 years ago

  • Subject changed from v2::Checker should enforce sig-type check to validator_config::Checker should enforce sig-type check
  • Description updated (diff)
  • Status changed from New to Code review
Actions #14

Updated by Davide Pesavento over 3 years ago

  • Status changed from Code review to Closed
  • % Done changed from 90 to 100
Actions

Also available in: Atom PDF