NFD » ndn-cxx

I'm not sure if this is worthwhile...

This IS worthwhile. The codebase should not leave any developer confused. Having documentation is always better than not having them.
In fact, I would not use the macro until this documentation is in place, and therefore this blocks #4526.

we will soon be able to require C++14, at that point we can drop the macro altogether and use the standard attribute [[deprecated]] directly (which can be used in more situations)

This is irrelevant to the need of having documentation NOW. Dropping the macro removes the documentation and tests, of course.

Junxiao Shi wrote:

This is irrelevant to the need of having documentation NOW. Dropping the macro removes the documentation and tests, of course.

On the contrary, it is very relevant. There really is no point in documenting something that we know will be removed in a month or two. Moreover, not documenting it reduces that chances that other projects will start using it, and then break when we remove it.

and don't add ridiculous blockers please...

In this case, I will not work on any commit that rely on this macro. They will be blocked until this macro is removed.

Note that I haven't -1'd the change. I still think it's pointless and I'm not changing my mind, but I don't care if someone else wants to merge it.