Task #4731
open
RIB: deduplicate RibManager::FaceIdSet and Rib::FaceLookupTable
60%
Description
RibManager maintains a FaceIdSet to detect missed face destroyed events.
Rib maintains a FaceLookupTable to delete affected routes when a face is destroyed.
These two data structures contain partially duplicate information, and should be combined.
Furthermore, FaceMonitor does not rely on RibManager's command processing and signature validation functions, so that it could be moved down to Rib class.
Updated by Davide Pesavento over 5 years ago
- Tags changed from code-cleanup to CodeCleanup
Updated by Junxiao Shi almost 5 years ago
- Status changed from New to In Progress
- Target version set to v0.7
Updated by Junxiao Shi almost 5 years ago
- % Done changed from 0 to 40
https://gerrit.named-data.net/5483 is the first Change. FaceMonitor moves next.
Updated by Junxiao Shi almost 5 years ago
- % Done changed from 40 to 50
https://gerrit.named-data.net/5518
I'm working on moving FaceMonitor. I plan to introduce a FaceSync type that works alongside Rib, instead of inserting the logic into Rib type itself; it is similar to FibUpdater type but probably less coupled. This keeps communications out of Rib type and reduces its complexity.
Updated by Junxiao Shi almost 5 years ago
https://gerrit.named-data.net/c/NFD/+/5578 changes Rib::onFibUpdateSuccess Rib::onFibUpdateFailure Rib::findDescendants Rib::findDescendantsForNonInsertedName from public to private. This is in preparation of FaceSync refactoring.
I understand that findDescendants findDescendantsForNonInsertedName functions have problematic names and semantics, but I'd keep them unchanged for now.
Updated by Junxiao Shi over 4 years ago
- % Done changed from 50 to 60
Still working on this. It's as complicated as I expected.
Updated by Junxiao Shi over 4 years ago
I'm seeing some problems in test cases related to mocked FIB responses. https://gerrit.named-data.net/c/NFD/+/5664 changes mocking method.
Updated by Davide Pesavento over 4 years ago
- Target version changed from v0.7 to 22.02
Updated by Junxiao Shi about 4 years ago
- Assignee deleted (
Junxiao Shi)
I will no longer work on this issue because FaceSync would become unnecessary after #4529.
Updated by Davide Pesavento almost 4 years ago
- Status changed from In Progress to Feedback
Updated by Davide Pesavento almost 4 years ago
- Tags changed from CodeCleanup to code-cleanup
Updated by Davide Pesavento about 3 years ago
- Priority changed from Normal to Low
- Target version deleted (
22.02)
Updated by Davide Pesavento about 3 years ago
- Blocked by Feature #4529: Merge NFD-RIB into management thread added