Task #4731
closed
RIB: deduplicate RibManager::FaceIdSet and Rib::FaceLookupTable
Added by Junxiao Shi over 6 years ago.
Updated 3 months ago.
Description
RibManager maintains a FaceIdSet to detect missed face destroyed events.
Rib maintains a FaceLookupTable to delete affected routes when a face is destroyed.
These two data structures contain partially duplicate information, and should be combined.
Furthermore, FaceMonitor does not rely on RibManager's command processing and signature validation functions, so that it could be moved down to Rib class.
- Tags changed from code-cleanup to CodeCleanup
- Status changed from New to In Progress
- Target version set to v0.7
- % Done changed from 0 to 40
- % Done changed from 40 to 50
https://gerrit.named-data.net/5518
I'm working on moving FaceMonitor. I plan to introduce a FaceSync type that works alongside Rib, instead of inserting the logic into Rib type itself; it is similar to FibUpdater type but probably less coupled. This keeps communications out of Rib type and reduces its complexity.
https://gerrit.named-data.net/c/NFD/+/5578 changes Rib::onFibUpdateSuccess Rib::onFibUpdateFailure Rib::findDescendants Rib::findDescendantsForNonInsertedName from public to private. This is in preparation of FaceSync refactoring.
I understand that findDescendants findDescendantsForNonInsertedName functions have problematic names and semantics, but I'd keep them unchanged for now.
- % Done changed from 50 to 60
- Target version changed from v0.7 to 22.02
- Assignee deleted (
Junxiao Shi)
I will no longer work on this issue because FaceSync would become unnecessary after #4529.
- Status changed from In Progress to Feedback
- Tags changed from CodeCleanup to code-cleanup
- Priority changed from Normal to Low
- Target version deleted (
22.02)
- Blocked by Feature #4529: Merge NFD-RIB into management thread added
- Blocked by deleted (Feature #4529: Merge NFD-RIB into management thread)
- Status changed from Feedback to Abandoned
Also available in: Atom
PDF
Updated by 
Updated by