Task #4780
closedMake Interest Parameters TLV non-critical
100%
Description
As discussed on 2018-11-26, the Interest Parameters element should be redefined to use a non-critical TLV-TYPE.
Updated by Davide Pesavento almost 6 years ago
- Status changed from New to In Progress
- Assignee set to Davide Pesavento
- % Done changed from 0 to 30
spec change https://gerrit.named-data.net/c/NDN-TLV/+/5201
Updated by Junxiao Shi almost 6 years ago
As discussed on 20190130 NFD call, a range of TLV-TYPE numbers indicates of the start of digest computation area for ParametersSha256DigestComponent.
I'd suggest renumbering Parameters to 0x30 instead of 0x24, so that bitwise expression (tlvType & 0xF0) == 0x30
identifies this range.
Updated by Davide Pesavento almost 6 years ago
Junxiao Shi wrote:
I'd suggest renumbering Parameters to 0x30 instead of 0x24, so that bitwise expression
(tlvType & 0xF0) == 0x30
identifies this range.
err... why? [48-63] or [36-51], what's the difference? both intervals are currently unassigned.
Updated by Junxiao Shi almost 6 years ago
Bitwise operator is better than inequal comparison operator, at least in hardware implementation (think electric circuits where it needs less gates).
Although the need for hardware implementation at this level may be sparse, there’s no harm in assigning a hardware-friendly number.
Updated by Junxiao Shi almost 6 years ago
- Related to Feature #4831: Redefine ParametersSha256DigestComponent covered area added
Updated by Davide Pesavento over 5 years ago
Shouldn't ParametersSha256DigestComponent
also be non-critical? What's the point of having one critical but not the other?
Updated by Junxiao Shi over 5 years ago
Shouldn't
ParametersSha256DigestComponent
also be non-critical? What's the point of having one critical but not the other?
Evolvability rules do not apply to name component types.
Updated by Davide Pesavento over 5 years ago
- % Done changed from 30 to 80
ndn-cxx implementation update https://gerrit.named-data.net/c/ndn-cxx/+/5217
Updated by Davide Pesavento over 5 years ago
- Status changed from In Progress to Code review
- % Done changed from 80 to 100
Wireshark dissector update https://gerrit.named-data.net/c/ndn-tools/+/5239
Updated by Davide Pesavento over 5 years ago
- Status changed from Code review to Closed