Bug #5049
closed
Fix ValidatorConfig behavior with empty configuration
100%
Description
The current ValidationPolicyConfig throws an exception when loading empty config section. A better behavior would be:
- allow loading an empty config file/section without throwing
- fail any validation attempts when the configuration is empty
Updated by Davide Pesavento over 4 years ago
- Tracker changed from Task to Bug
- Category set to Security
Updated by Davide Pesavento over 4 years ago
- Subject changed from Improve validator behavior: empty config section can be loaded but fails validation to Fix ValidatorConfig behavior with empty configuration
- Description updated (diff)
Updated by Davide Pesavento over 4 years ago
Teng Liang wrote:
The current
ValidationPolicyConfigthrows an exception when loading empty config section, but then allows any validation.
I did not observe the second part of the behavior described above ("allows any validation"). @Teng, can you explain how to reproduce that?
Updated by Davide Pesavento over 4 years ago
- Status changed from New to Code review
- Assignee set to Davide Pesavento
- Target version set to v0.7
Updated by Davide Pesavento over 4 years ago
- Blocks Feature #5031: Make NFD work out of the box added
Updated by Teng Liang over 4 years ago
Davide Pesavento wrote:
Teng Liang wrote:
The current
ValidationPolicyConfigthrows an exception when loading empty config section, but then allows any validation.I did not observe the second part of the behavior described above ("allows any validation"). @Teng, can you explain how to reproduce that?
The test case in https://gerrit.named-data.net/c/NFD/+/5776/12/tests/daemon/mgmt/rib-manager-sl-announce.t.cpp#182, the validation should fail but succeed.
Updated by Davide Pesavento over 4 years ago
Teng Liang wrote:
Davide Pesavento wrote:
Teng Liang wrote:
The current
ValidationPolicyConfigthrows an exception when loading empty config section, but then allows any validation.I did not observe the second part of the behavior described above ("allows any validation"). @Teng, can you explain how to reproduce that?
The test case in https://gerrit.named-data.net/c/NFD/+/5776/12/tests/daemon/mgmt/rib-manager-sl-announce.t.cpp#182, the validation should fail but succeed.
I still cannot reproduce (after applying the ndn-cxx patch of course, there's no way to test without it). Test cases behave as expected.
Updated by Davide Pesavento over 4 years ago
- Description updated (diff)
- Status changed from Code review to Closed
- % Done changed from 0 to 100