NFD

Does the long list of nonces cause any problem right now? performance? correctness?

A quick and dirty fix is to put a limit on the number of nonces kept in the PIT entry.

If nonce is only used for loop detection, then only the nonces of outgoing interests need to be recorded, which should be much less than that of incoming interests. A small number, say 10, may be enough.

If there's a need to keep nonces of incoming interests, would one per incoming face be sufficient?

yes. The problem, I suspect, is right now. After an hour, NLSR interests start being rejected and bad things start to happen.

I asked Hoque to make a test with completely disable loop detection to see if this is the core of the problem or something else.

From the test Hoque did, it seems that the core problem is not this one, though we should fix this one anyways.

I have found another problem with rib self-registrations (#1772) that probably is real reason. Will report more as I have results from new tests.

Suppose an Interest is expressed once a second, the probability of having a duplicate Nonce after one month is 0.06%.
Thus I don't think this is a critical problem in terms of correctness.

The growing Nonce list takes memory, which is a problem.
Nonce list for one Interest, expressed once per second, needs 10MB memory after a month.

I agree with the solution in note-2.
The limit could be 256 Nonces (1KB memory).

Don't close the task without creating another task. Otherwise, this will hide the "problem".

I disagree with the alternate solution so I don't create the Task.
Whoever pushing for another solution should create the Task.

So, you're trying to hide/ignore the problem. This is not correct.