Project

General

Profile

Actions

Task #1780

closed

Link layer byte count in EthernetFace

Added by Junxiao Shi over 10 years ago. Updated over 10 years ago.

Status:
Closed
Priority:
Normal
Category:
Faces
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
3.00 h

Description

Increment link layer byte counters on sending path and receiving path of EthernetFace.

The counters need not distinguish between network layer packet types.


Related issues 1 (0 open1 closed)

Blocked by NFD - Task #1729: Add byte counters to FaceCountersClosedJunxiao Shi

Actions
Actions #1

Updated by Junxiao Shi over 10 years ago

  • Blocked by Task #1209: NDNLP fragmentation and reassembly on Ethernet multicast face added
Actions #2

Updated by Junxiao Shi over 10 years ago

  • Blocked by Task #1729: Add byte counters to FaceCounters added
Actions #3

Updated by Alex Afanasyev over 10 years ago

  • Target version set to v0.2
Actions #4

Updated by Davide Pesavento over 10 years ago

This task does not need to depend on #1209. Byte counters can be implemented now by counting the payload of ethernet frames. When fragmentation is implemented, we can simply add the size of NDNLP headers to the counters.

Actions #5

Updated by Junxiao Shi over 10 years ago

EthernetFace is not fully working without NDNLP.
There will be some changes for NDNLP support.
This I prefer to defer this until NDNLP is supported.

Actions #6

Updated by Junxiao Shi over 10 years ago

  • Blocked by deleted (Task #1209: NDNLP fragmentation and reassembly on Ethernet multicast face)
Actions #7

Updated by Junxiao Shi over 10 years ago

  • Assignee set to Davide Pesavento

Since @Davide knows how to do this without #1209, I'm assigning this Task to him.

Actions #8

Updated by Davide Pesavento over 10 years ago

Should the zero-padding added in the send path be counted? (I think so)

Actions #9

Updated by Davide Pesavento over 10 years ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 50
Actions #10

Updated by Junxiao Shi over 10 years ago

Davide Pesavento wrote:

Should the zero-padding added in the send path be counted? (I think so)

No. TCP headers are excluded, so Ethernet trailers are also excluded.

Actions #11

Updated by Davide Pesavento over 10 years ago

The padding is not part of the ethernet frame header or trailer, it's added to the ethernet frame payload when the data (upper-layer packet) is shorter than the minimum payload length allowed by the ethernet standard.

In any case, I'm fine either way, just wanted to be sure that there's no misunderstanding.

Actions #12

Updated by Davide Pesavento over 10 years ago

  • Status changed from In Progress to Code review
  • % Done changed from 50 to 100
Actions #13

Updated by Alex Afanasyev over 10 years ago

  • Status changed from Code review to Closed
Actions

Also available in: Atom PDF