Task #1780
closed
Link layer byte count in EthernetFace
Added by Junxiao Shi over 10 years ago.
Updated over 10 years ago.
Description
Increment link layer byte counters on sending path and receiving path of EthernetFace.
The counters need not distinguish between network layer packet types.
- Blocked by Task #1209: NDNLP fragmentation and reassembly on Ethernet multicast face added
- Blocked by Task #1729: Add byte counters to FaceCounters added
- Target version set to v0.2
This task does not need to depend on #1209. Byte counters can be implemented now by counting the payload of ethernet frames. When fragmentation is implemented, we can simply add the size of NDNLP headers to the counters.
EthernetFace is not fully working without NDNLP.
There will be some changes for NDNLP support.
This I prefer to defer this until NDNLP is supported.
- Blocked by deleted (Task #1209: NDNLP fragmentation and reassembly on Ethernet multicast face)
- Assignee set to Davide Pesavento
Since @Davide knows how to do this without #1209, I'm assigning this Task to him.
Should the zero-padding added in the send path be counted? (I think so)
- Status changed from New to In Progress
- % Done changed from 0 to 50
Davide Pesavento wrote:
Should the zero-padding added in the send path be counted? (I think so)
No. TCP headers are excluded, so Ethernet trailers are also excluded.
The padding is not part of the ethernet frame header or trailer, it's added to the ethernet frame payload when the data (upper-layer packet) is shorter than the minimum payload length allowed by the ethernet standard.
In any case, I'm fine either way, just wanted to be sure that there's no misunderstanding.
- Status changed from In Progress to Code review
- % Done changed from 50 to 100
- Status changed from Code review to Closed
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by