NFD

This Task has interlocked dependency with #1991. Suggested procedure is:

1. In #1992, make changes to ndn::nfd::FaceStatus type, and mark old API as obsolete.
2. #1991 and rest of #1992 can be worked in parallel.
3. In #1992, delete old API after #1991 is completed.

Another part of this task is change Face::getFaceStatus and Face Dataset, should this part submit with #1991 or just submit as #1992 in NFD repository?

After the Change for ndn::nfd::FaceStatus type and ndn::nfd::FaceEventNotification type is merged, you can make two separate Changes for #1991 and rest of #1992 (except deleting old API). Those can be worked on in parallel.

After both of those Changes are merged, make a fourth Change to delete old API.

Changes have been merged into ndn-cxx and corresponding changes need to be made to NFD. Currently, the master branch of NFD doesn't compile with the master branch of ndn-cxx.

will commit the change soon

The recently merged ndn-cxx commit is designed to be backwards-compatible, but a file is renamed and we forget to set a alias at old file name.

We should make a urgent commit to ndn-cxx that makes a symbolic link from nfd-face-flags.hpp to nfd-face-traits.hpp.

Can I just quickly commit the one to fix this issue, and latter commit others?

The quick fix is let face/face.hpp include the header nfd-face-traits.hpp, instead of nfd-face-flags.hpp.

No, you should update ndn-cxx to make it backward-compatible, not update NFD.

To test for backwards-compatibility, compile unchanged NFD and NLSR, and they should succeed.

For deleting deprecated APIs, do you mean delete the deprecated APIs in ndn-cxx?

Should it be done recently?

Yes, obsolete APIs can be deleted now.

The purpose of making the first commit backwards-compatible is to avoid breaking NFD outright.
After #1991 completion, NFD shouldn't have any code using obsolete APIs.

I think the obsolete APIs contain the face flag setter and getter, isLocal, isOnDemand, and FaceFlags enum.

But there are still some NFD codes use some of them:

1. tests/daemon/mgmt/face-manager.cppm line 1602, 1664 use setFlags()
2. tools/nfd-autoreg.cpp, line 162, 167, and 298 use isLocal or isOnDemand

I'll modify them first, and then move the obsolete APIs in ndn-cxx.
If I misunderstand anything, please let me know.

If there's any NFD code that uses obsolete APIs, they should be changed as part of this Task.