Task #2132: code-style: assert - ndn-cxx - NDN project issue tracking system

Task #2132

closed

code-style: assert

Added by Junxiao Shi over 9 years ago. Updated over 9 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Junxiao Shi

Category:

Docs

Target version:

v0.3

Start date:

Due date:

% Done:

100%

Estimated time:

0.50 h

Description

Add code style rule for assert vs BOOST_ASSERT, static_assert vs BOOST_STATIC_ASSERT.

Related issues 1 (0 open — 1 closed)

Blocks ndn-cxx - Task #1983: Ensure Element::Error inherits from tlv::Error

Closed

Junxiao Shi

Actions

Issue # Delay: days Cancel

History
Notes
Property changes

Actions

Copy link

Updated by Junxiao Shi over 9 years ago

I would preferred BOOST_*, because they are upper case and more eye-catching.

Are there different opinions?

Actions

Copy link

Updated by Davide Pesavento over 9 years ago

I would use the standard version. You can always #define NDN_ASSERT assert if you like uppercase, but I don't really understand nor agree with the "eye-catching" rationale...

Actions

Copy link

Updated by Yingdi Yu over 9 years ago

I would agree with Davide. Given we should "eventually" replace all the BOOST stuff with stl, we should introduce as few BOOST things as possible. Defining an NDN_ASSERT macro seems a good solution.

Actions

Copy link

Updated by Junxiao Shi over 9 years ago

Don't introduce new identifiers.

If BOOST_* is undesirable, we should prefer plain assert and static_assert.

Actions

Copy link

Updated by Alex Afanasyev over 9 years ago

I don't mind using static_assert instead of BOOST_STATIC_ASSERT, but would prefer using boost's BOOST_ASSERT and BOOST_ASSERT_MSG as they provide more functionality than standard assert (http://www.boost.org/doc/libs/1_55_0/libs/utility/assert.html)

Actions

Copy link