Bug #2299
closed
std::snprintf not found in buggy STL implementations
Added by Alex Afanasyev over 9 years ago. Updated about 9 years ago.
100%
Description
At least with cygwin, does not properly define std::snprintf, but C's version ::snprintf is still available.
I'm proposing changing instances of std::snprintf with the following:
// inside function body
using namespace std;
snprintf(...);
Files
| snprintf.patch (1.36 KB) snprintf.patch | Mathias Gibbens, 04/13/2015 11:08 AM |
Updated by Junxiao Shi over 9 years ago
I disagree with the proposed solution. using namespace should be avoided.
- check for
std::snprintfduring configure step - in common.hpp, declare
std::snprintfas a function that forwards its arguments to::snprintf
Updated by Alex Afanasyev over 9 years ago
This technique is used in many places in boost libraries and I don't see problem with that.
We can check during configure stage, but then it is just more complicated to use, while there is a simple solution that should solve all the problems.
Updated by Alex Afanasyev over 9 years ago
I decided to reject this task, as it is just a really buggy cygwin implementation. Code can be compiled with addition of a few defines.
Updated by Alex Afanasyev over 9 years ago
- Status changed from Rejected to New
I'm reopening this, as android compilation has exactly the same problem, and unfortunately I cannot fix it with a few extra defines.
Updated by Davide Pesavento over 9 years ago
Just use the C version, as it was before we moved to C++11.
Updated by Alex Afanasyev over 9 years ago
- Assignee set to Alex Afanasyev
- Target version set to v0.3
Will replace with C version of snprintf
Updated by Alex Afanasyev over 9 years ago
- Status changed from New to In Progress
Updated by Alex Afanasyev over 9 years ago
- Status changed from In Progress to Code review
- % Done changed from 0 to 100
Updated by Alex Afanasyev over 9 years ago
- Status changed from Code review to In Progress
- % Done changed from 100 to 70
Similar fix needs to be done in NFD codebase. Will submit new patch later.
Updated by Alex Afanasyev over 9 years ago
- Status changed from In Progress to Code review
- % Done changed from 70 to 100
Updated by Junxiao Shi about 9 years ago
- Status changed from Code review to Closed
Updated by Mathias Gibbens about 9 years ago
I hit this problem today using OpenWRT's build toolchain (gcc 4.8.3) when cross-compiling NFD 0.3.1. There is a usage of std::snprintf in ./daemon/face/ethernet-face.cpp that is causing the same problem. Alex's previous patch only fixed the issue in ./core/logger.cpp. There are no other occurrences of snprintf in the NFD 0.3.1 code.
Can we get a fix for this included in the next NFD release?
Updated by Junxiao Shi about 9 years ago
- Status changed from Closed to Feedback
- Target version changed from v0.3 to v0.4
Reopening as requested by a Mathias.
Updated by Alex Afanasyev about 9 years ago
@Mathias Can you submit your patch for the code review?
Updated by Mathias Gibbens about 9 years ago
- File snprintf.patch snprintf.patch added
Here is a patch against the current NFD master branch that fixes the issue. It is modeled after Alex's previous two patches.
Updated by Alex Afanasyev about 9 years ago
@Mathias, can you please push your patchset to http://gerrit.named-data.net/?
Updated by Mathias Gibbens about 9 years ago
@Alex, I don't have an account setup for the project's Gerrit. This is such a small patch that I'd like to not go through the trouble of setting up another account just to commit it. I'd be fine with either you or Junxiao committing it.
Updated by Alex Afanasyev about 9 years ago
- Status changed from Feedback to Code review
Updated by Junxiao Shi about 9 years ago
- Status changed from Code review to Closed