Project

General

Profile

Actions

Task #2402

closed

Do not advertise Adjacency LSAs when hyperbolic routing is enabled

Added by Vince Lehman almost 10 years ago. Updated over 8 years ago.

Status:
Closed
Priority:
Normal
Target version:
Start date:
01/21/2015
Due date:
% Done:

0%

Estimated time:

Description

Currently, when hyperbolic routing is enabled, Adjacency LSAs are distributed throughout the network.

But, in hyperbolic routing the Adjacency LSAs are not used to make routing decisions.

When hyperbolic routing is enabled, routers should not advertise their Adjacency LSAs.


Related issues 2 (0 open2 closed)

Related to NLSR - Task #3661: Do not distribute Coordinate LSAs when using link-state routingClosedNicholas Gordon07/07/2016

Actions
Related to NLSR - Task #2776: Remove unnecessary routing table calculations in hyperbolic routingClosedAshlesh Gawande04/28/201506/16/2017

Actions
Actions #1

Updated by Nicholas Gordon over 8 years ago

  • Status changed from New to Feedback
  • Assignee set to Nicholas Gordon

07/06/16: Solution completed. Submitting code for feedback by a senior developer on the project.

Actions #2

Updated by Nicholas Gordon over 8 years ago

  • Status changed from Feedback to Code review
Actions #3

Updated by Nicholas Gordon over 8 years ago

  • Related to Task #3661: Do not distribute Coordinate LSAs when using link-state routing added
Actions #4

Updated by Nicholas Gordon over 8 years ago

Part of the implementation for this patch was the extension of the unit test. This extension was also necessary to make issue #3661 test-compliant as well. what was wrong:

The Sync updates encode the new LSA sequence numbers into the bits of a 64-bit number. This number is passed to the constructor of a SyncUpdate object which in turn creates a sequence manager, the job of which is to decode that compound sequence number into the corresponding numbers for each of the current LSA types (Name, Adjacency, and Coordinate).

Now, in the unit test, there is a function that simulates Sync receiving an update, and the missing sequence number was being encoded as "1". What this means is that the bits were: 000...001, so the name- and coordinate LSA sequence numbers were being set to 0. Passing a correctly-constructed sequence number depending on the routing configuration enabled (LS, HR, or dry HR) resolved the problem.

Actions #5

Updated by Muktadir Chowdhury over 8 years ago

  • Target version set to v0.3.0
Actions #6

Updated by Muktadir Chowdhury over 8 years ago

  • Status changed from Code review to Closed
Actions #7

Updated by Ashlesh Gawande over 7 years ago

  • Related to Task #2776: Remove unnecessary routing table calculations in hyperbolic routing added
Actions

Also available in: Atom PDF