NFD » ndn-tools

I feel the --enable-X and --disable-X combination is too complex, and the help messages associated with those configuration options cannot clearly convey the select/deselect logic.

What about the alternate design:

• Declare a single command line option: --enable-tools=X,Y,Z.
• The argument to this command line option is a comma-separated list where each token is the directory name of a tool.
• The help message should display the full list.
• When this option is specified, only those tools appearing in the list are selected, and all other tools are deselected.
• When this option is omitted, all tools are selected.

Also, when a tool is deselected, its unit testing should not be built. Therefore, this Feature is blocked by #2795.

this is not big difference as I can see. I prefer to stick on the commonly used way, enable-X, disable-X, which seems more explicit.

commit:4e99475245535b63b569e89e786c5a2e7b3e00a2 correctly implements the selection of programs and test suites.

However, all manpages are built regardless of the selections.

Since we placed all manpages in the same directory, I can't think of a feasible solution to select which manpages to build.

I have tested commit:331784dd439c5526c72373f2dd610167de7d0659 with below configure lines.
All configure lines are working correctly.

./waf configure --enable-ping --disable-ping

Expected: error

./waf configure --disable-ping --enable-ping

Expected: error

./waf configure --enable-ping

Expected: no libpcap detection; build ping

./waf configure --disable-dump

Expected: no libpcap detection; do not build dump

./waf configure --with-tests --enable-ping

Expected: build unit testing for ping

./waf configure --with-tests --disable-ping

Expected: do not build unit testing for ping

./waf configure --with-tests --enable-dump

Expected: do not build unit testing for ping

./waf configure --with-tests

Expected: build all tools; build unit testing for ping