Project

General

Profile

Task #3082

Allow configuration file to be reloaded while NLSR is running

Added by Vince Lehman over 4 years ago. Updated 4 months ago.

Status:
Code review
Priority:
Normal
Assignee:
Target version:
Start date:
08/07/2015
Due date:
% Done:

90%

Estimated time:

Description

Currently, any changes to the parameters in the NLSR configuration file require NLSR to be restarted to take effect.

Instead, NLSR should subscribe to a signal and reload the configuration file in a manner similar to NFD.

Necessary changes:

  • main.cpp - listen for SIGHUP signal to trigger configuration reload; on signal, reload configuration file and notify NLSR
  • nlsr.cpp - An Nlsr::onConfigReload method should be added where clean up or application of newly loaded configuration options can be handled

This task should provide the ability for parameters to be reloaded but should not implement the logic for each parameter. The logic for certain parameters should be added as necessary in separate tasks.


Related issues

Blocked by NLSR - Task #3091: Implement NlsrRunner class in main.cppClosed08/10/2015

Actions

History

#1

Updated by Vince Lehman over 4 years ago

  • Assignee set to Benjamin Murphy
#2

Updated by Vince Lehman over 4 years ago

  • Blocked by Task #3091: Implement NlsrRunner class in main.cpp added
#3

Updated by Vince Lehman over 4 years ago

  • Description updated (diff)
#4

Updated by Vince Lehman over 4 years ago

  • Assignee changed from Benjamin Murphy to Vince Lehman
#5

Updated by Vince Lehman over 4 years ago

  • Description updated (diff)
#6

Updated by Vince Lehman over 4 years ago

  • Status changed from New to Code review
  • % Done changed from 0 to 90
#7

Updated by Junxiao Shi over 4 years ago

This commit is in response to a request from John DeHart for the ability to change link costs on configuration reload. I'm trying to think of a clean way to only allow this option for right now and document that any other changes will be ignored.

Changing link costs can be done through nlsrc (add a setcost subcommand).

Using a configuration reload to change link costs would cause more trouble, such as: what if an existing link is deleted (the new cost would be undefined)?

#8

Updated by Vince Lehman almost 4 years ago

  • Assignee deleted (Vince Lehman)
#9

Updated by Nicholas Gordon almost 3 years ago

  • Target version set to v0.5.0
#10

Updated by Nicholas Gordon about 2 years ago

  • Assignee set to Ashlesh Gawande
#11

Updated by Nicholas Gordon about 2 years ago

  • Target version changed from v0.5.0 to v0.6.0
#12

Updated by Ashlesh Gawande 4 months ago

  • Assignee changed from Ashlesh Gawande to Saurab Dulal

Also available in: Atom PDF