Project

General

Profile

Actions
Copy link

Task #3172

closed

Refactor Face: completion

Added by Junxiao Shi about 9 years ago. Updated almost 9 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Junxiao Shi
Category:
Faces
Target version:
v0.4
Start date:
Due date:
% Done:

100%

Estimated time:
6.00 h

Description

Complete Face refactoring as LinkService+Transport.

  • Delete old Face.
  • Rename LpFace as Face.
  • Modify Channel and Factory subclasses to return Face directly without wrapping into LpFaceWrapper.
  • Delete LpFaceWrapper.
  • Modify forwarding and management to use new Face methods, signals, and counters.

Files

integ2632,5.tar.xz (70.3 KB) integ2632,5.tar.xz integ with NFD 2632,5 Junxiao Shi, 12/24/2015 06:15 PM

Related issues 13 (0 open — 13 closed)

Related to NFD - Feature #3173: Developer Guide: Face=LinkService+Transport and GenericLinkServiceClosedJunxiao Shi

Actions
Blocked by NFD - Feature #3165: UnixStreamTransportClosedYukai Tu

Actions
Blocked by NFD - Feature #3166: TcpTransportClosedYukai Tu

Actions
Blocked by NFD - Feature #3168: UdpTransportClosedYukai Tu

Actions
Blocked by NFD - Feature #3169: WebSocketTransportClosedYukai Tu

Actions
Blocked by NFD - Feature #3170: EthernetTransportClosedDavide Pesavento

Actions
Blocked by NFD - Feature #3177: LpFace countersClosedJunxiao Shi

Actions
Blocked by NFD - Task #3225: Refactor InternalFaceClosedJunxiao Shi

Actions
Blocked by NFD - Bug #3262: MulticastUdpTransport does not set remoteEndpointClosedDavide Pesavento

Actions
Blocked by NFD - Task #3278: Refactor NullFaceClosedJunxiao Shi

Actions
Blocked by NFD - Task #3305: UnixStreamTransport: test suite improvementClosedEric Newberry

Actions
Blocked by NFD - Task #3306: TcpTransport: test suite improvementClosedEric Newberry

Actions
Blocked by NFD - Task #3307: UnicastUdpTransport: test suite improvementClosedEric Newberry

Actions
Actions
Copy link
 #1

Updated by Junxiao Shi about 9 years ago

  • Description updated (diff)
  • Estimated time changed from 1.50 h to 3.00 h
Actions
Copy link
 #2

Updated by Junxiao Shi about 9 years ago

Actions
Copy link
 #3

Updated by Junxiao Shi about 9 years ago

Actions
Copy link
 #4

Updated by Junxiao Shi about 9 years ago

Actions
Copy link
 #5

Updated by Junxiao Shi about 9 years ago

Actions
Copy link
 #6

Updated by Junxiao Shi about 9 years ago

Actions
Copy link
 #7

Updated by Junxiao Shi about 9 years ago

  • Related to Feature #3173: Developer Guide: Face=LinkService+Transport and GenericLinkService added
Actions
Copy link
 #8

Updated by Junxiao Shi about 9 years ago

Actions
Copy link
 #9

Updated by Junxiao Shi about 9 years ago

  • Blocked by Task #3225: Refactor InternalFace added
Actions
Copy link
 #10

Updated by Davide Pesavento about 9 years ago

Also consider swapping "local=..." and "remote=..." in the log messages in fw/face-table.cpp, for consistency with transport and link service messages.

Actions
Copy link
 #11

Updated by Junxiao Shi about 9 years ago

  • Blocked by Bug #3262: MulticastUdpTransport does not set remoteEndpoint added
Actions
Copy link
 #12

Updated by Junxiao Shi about 9 years ago

Actions
Copy link
 #13

Updated by Junxiao Shi about 9 years ago

  • Blocked by Task #3305: UnixStreamTransport: test suite improvement added
Actions
Copy link
 #14

Updated by Junxiao Shi about 9 years ago

  • Blocked by Task #3306: TcpTransport: test suite improvement added
Actions
Copy link
 #15

Updated by Junxiao Shi about 9 years ago

  • Blocked by Task #3307: UnicastUdpTransport: test suite improvement added
Actions
Copy link
 #16

Updated by Junxiao Shi about 9 years ago

  • Blocked by Task #3346: MulticastUdpTransport: test suite improvement added
Actions
Copy link
 #17

Updated by Junxiao Shi almost 9 years ago

  • Assignee set to Junxiao Shi

I'll work on this on Dec 23.

20151217 conference call agrees that the Change for this issue will not need to be rebased.

Actions
Copy link
 #18

Updated by Junxiao Shi almost 9 years ago

  • Status changed from New to In Progress
  • Estimated time changed from 3.00 h to 6.00 h
Actions
Copy link
 #19

Updated by Junxiao Shi almost 9 years ago

  • Blocked by deleted (Task #3346: MulticastUdpTransport: test suite improvement)
Actions
Copy link
 #20

Updated by Davide Pesavento almost 9 years ago

ethernet.t.cpp still has a ProcessIncomingPacket test case with no counterpart in ethernet-transport.t.cpp. What do you want to do with it?

Actions
Copy link
 #21

Updated by Junxiao Shi almost 9 years ago

  • % Done changed from 0 to 10

http://gerrit.named-data.net/2632

patchset1 shows what test cases are kept, and what test cases are deleted. In particular, many Channel test cases are deleted because they rely on specific features in the old Face. I will create separate Tasks to re-add them later.

Actions
Copy link
 #22

Updated by Junxiao Shi almost 9 years ago

  • % Done changed from 10 to 50

http://gerrit.named-data.net/2632 patchset2 contains all the changes in daemon/. It builds when --with-tests is not specified on configure line, and the nfd binary works with ndnping.

I'll get into tests/ next.

Actions
Copy link
 #23

Updated by Junxiao Shi almost 9 years ago

  • % Done changed from 50 to 80

http://gerrit.named-data.net/2632 patchset3 fixes the build of test cases, except tests/daemon/mgmt/face-manager-create-face.t.cpp that I can't fully understand and is temporarily deleted (it shall be restored before merging).

There are 10 test execution failures and I'll look into them.

Also, since reviewers are complaining about a minor refactoring of UdpChannel that is mixed into this Change, I've separated it out to http://gerrit.named-data.net/2633.

Actions
Copy link
 #24

Updated by Alex Afanasyev almost 9 years ago

I also got a failure of Face/TestTcpTransport test case with patchset 3:

../tests/daemon/face/tcp-transport-fixture.hpp:73: fatal error: in "Face/TestTcpTransport/StaticPropertiesNonLocalIpv6": critical check limitedIo.run(2, time::seconds(1)) == LimitedIo::EXCEED_OPS has failed [2 != 1]
Actions
Copy link
 #25

Updated by Junxiao Shi almost 9 years ago

  • Status changed from In Progress to Code review
  • % Done changed from 80 to 100

http://gerrit.named-data.net/2632 patchset4 is complete.

I'll run IntegrationTests if build is passing on Jenkins.

Actions
Copy link
 #26

Updated by Junxiao Shi almost 9 years ago

Actions
Copy link

Also available in: Atom PDF