Task #3172
closed
Refactor Face: completion
Added by Junxiao Shi over 8 years ago. Updated over 8 years ago.
100%
Description
Complete Face refactoring as LinkService+Transport.
- Delete old
Face. - Rename
LpFaceasFace. - Modify
ChannelandFactorysubclasses to returnFacedirectly without wrapping intoLpFaceWrapper. - Delete
LpFaceWrapper. - Modify forwarding and management to use new
Facemethods, signals, and counters.
Files
| integ2632,5.tar.xz (70.3 KB) integ2632,5.tar.xz | integ with NFD 2632,5 | Junxiao Shi, 12/24/2015 06:15 PM |
Updated by Junxiao Shi over 8 years ago
- Description updated (diff)
- Estimated time changed from 1.50 h to 3.00 h
Updated by Junxiao Shi over 8 years ago
- Blocked by Feature #3165: UnixStreamTransport added
Updated by Junxiao Shi over 8 years ago
- Blocked by Feature #3166: TcpTransport added
Updated by Junxiao Shi over 8 years ago
- Blocked by Feature #3168: UdpTransport added
Updated by Junxiao Shi over 8 years ago
- Blocked by Feature #3169: WebSocketTransport added
Updated by Junxiao Shi over 8 years ago
- Blocked by Feature #3170: EthernetTransport added
Updated by Junxiao Shi over 8 years ago
- Related to Feature #3173: Developer Guide: Face=LinkService+Transport and GenericLinkService added
Updated by Junxiao Shi over 8 years ago
- Blocked by Feature #3177: LpFace counters added
Updated by Junxiao Shi over 8 years ago
- Blocked by Task #3225: Refactor InternalFace added
Updated by Davide Pesavento over 8 years ago
Also consider swapping "local=..." and "remote=..." in the log messages in fw/face-table.cpp, for consistency with transport and link service messages.
Updated by Junxiao Shi over 8 years ago
- Blocked by Bug #3262: MulticastUdpTransport does not set remoteEndpoint added
Updated by Junxiao Shi over 8 years ago
- Blocked by Task #3278: Refactor NullFace added
Updated by Junxiao Shi over 8 years ago
- Blocked by Task #3305: UnixStreamTransport: test suite improvement added
Updated by Junxiao Shi over 8 years ago
- Blocked by Task #3306: TcpTransport: test suite improvement added
Updated by Junxiao Shi over 8 years ago
- Blocked by Task #3307: UnicastUdpTransport: test suite improvement added
Updated by Junxiao Shi over 8 years ago
- Blocked by Task #3346: MulticastUdpTransport: test suite improvement added
Updated by Junxiao Shi over 8 years ago
- Assignee set to Junxiao Shi
I'll work on this on Dec 23.
20151217 conference call agrees that the Change for this issue will not need to be rebased.
Updated by Junxiao Shi over 8 years ago
- Status changed from New to In Progress
- Estimated time changed from 3.00 h to 6.00 h
Updated by Junxiao Shi over 8 years ago
- Blocked by deleted (Task #3346: MulticastUdpTransport: test suite improvement)
Updated by Davide Pesavento over 8 years ago
ethernet.t.cpp still has a ProcessIncomingPacket test case with no counterpart in ethernet-transport.t.cpp. What do you want to do with it?
Updated by Junxiao Shi over 8 years ago
- % Done changed from 0 to 10
http://gerrit.named-data.net/2632
patchset1 shows what test cases are kept, and what test cases are deleted. In particular, many Channel test cases are deleted because they rely on specific features in the old Face. I will create separate Tasks to re-add them later.
Updated by Junxiao Shi over 8 years ago
- % Done changed from 10 to 50
http://gerrit.named-data.net/2632 patchset2 contains all the changes in daemon/. It builds when --with-tests is not specified on configure line, and the nfd binary works with ndnping.
I'll get into tests/ next.
Updated by Junxiao Shi over 8 years ago
- % Done changed from 50 to 80
http://gerrit.named-data.net/2632 patchset3 fixes the build of test cases, except tests/daemon/mgmt/face-manager-create-face.t.cpp that I can't fully understand and is temporarily deleted (it shall be restored before merging).
There are 10 test execution failures and I'll look into them.
Also, since reviewers are complaining about a minor refactoring of UdpChannel that is mixed into this Change, I've separated it out to http://gerrit.named-data.net/2633.
Updated by Alex Afanasyev over 8 years ago
I also got a failure of Face/TestTcpTransport test case with patchset 3:
../tests/daemon/face/tcp-transport-fixture.hpp:73: fatal error: in "Face/TestTcpTransport/StaticPropertiesNonLocalIpv6": critical check limitedIo.run(2, time::seconds(1)) == LimitedIo::EXCEED_OPS has failed [2 != 1]
Updated by Junxiao Shi over 8 years ago
- Status changed from In Progress to Code review
- % Done changed from 80 to 100
http://gerrit.named-data.net/2632 patchset4 is complete.
I'll run IntegrationTests if build is passing on Jenkins.
Updated by Junxiao Shi over 8 years ago
- File integ2632,5.tar.xz integ2632,5.tar.xz added
- Status changed from Code review to Closed