NFD

Does other transport need this setEndpintId? If so, I would prefer put the calculate method into parent class.

Does other transport need this setEndpintId?

MulticastUdpTransport is currently the only transport that needs to derive EndpointId from an IP address.

The other two IP-based transports, UnicastUdpTransport and TcpTransport, are both point-to-point, so they just need to keep EndpointId as zero.

RemoteEndpoint is for transport who send packet or who receive packet?

RemoteEndpoint is for transport who send packet or who receive packet?

EndpointId is needed on receive path only. It should indicate the sender of a received packet.

I am not sure it will work because only Transport::packet::packet is wrote into buffer, field RemoteEndpointId is not.

only Transport::packet::packet is wrote into buffer, field RemoteEndpointId is not.

There's no concept of "buffer" at API level.

Transport::Packet::remoteEndpoint needs to be set correctly when passed to Transport::receive.
How it's used later is out of scope of this issue.

Sorry I still can't have a good understanding. Receive logic is in datagram-transport, where does remoteEndpoint come from at this transport?

I think we have to use async_receive_from.

Btw, I can take over this task if you want.

@Davide:

Thanks! If this task is very urgent, or I can have a try.

I'm sorry for delaying this task.

I don't think it's urgent, given that fragmentation/reassembly in GenericLinkService hasn't been implemented yet. Take your time.

@Davide:

Thanks:)

I updated my ndn-cxx and NFD, but I still can't build NFD successfully. Here are messages:

In file included from ../tests/daemon/face/websocket-transport.t.cpp:29:0:
../tests/daemon/face/transport-properties.hpp: In function ‘void nfd::face::tests::checkStaticPropertiesInitialized(const nfd::face::Transport&)’:
../tests/daemon/face/transport-properties.hpp:49:1: error: ‘FACE_SCOPE_NONE’ is not a member of ‘ndn::nfd’
../tests/daemon/face/transport-properties.hpp:50:1: error: ‘FACE_PERSISTENCY_NONE’ is not a member of ‘ndn::nfd’
../tests/daemon/face/transport-properties.hpp:51:1: error: ‘LINK_TYPE_NONE’ is not a member of ‘ndn::nfd’

are you sure you installed the new ndn-cxx after building it?

I used command

git clone ssh://myusername@gerrit.named-data.net:29418/ndn-cxx

then

./waf configure
./waf
./waf install
ldconfig

And I still can't build NFD.

And was the install step successful? Usually you need sudo to install, which is missing from your command.

I used root permission. And all steps successful. I will try to implement environment in another mechine.

Does latest version of NFD pass the building? I still can't make it...

Does latest version of NFD pass the building?

Should be YES.

Refer to Jenkins, or use ndn-cxx-breaks to find out.