NFD

Is removing the face2014 section from the manual part of this task or should I simply replace references to it with references to the new face section?

Update references to new section with a brief summary of what the face system is and consists of.

Understood. Is there a review process similar to gerrit for the nfd-docs repository?

Not really. You can just update the document and let us know about the progress. Afterwards, we'll check the document and give you feedback/suggest changes/close the issue if everything is ok.

Is removing the face2014 section from the manual part of this task

face2014 is to be removed in #3397.

Of course you MAY do multiple tasks in the same commit.
The procedure for nfd-docs is much looser than code repositories.

should I simply replace references to it with references to the new face section?

This is not only about "references".

If there are texts that conflicts with 2015 design, they should be updated.

Junxiao Shi wrote:

"Overview of NFD modules" figure:

• "dead Nonce list" table is missing.
• "status server" has been renamed "forwarder status manager".
• There's no prominent distinction between "local face" and "remote face".
• LinkService+Transport structure deserves to be mentioned.

This figure is an image embedded in a PDF. I can't seem to find the source document the image was created from. Do you know where I can find it?

"Overview of NFD modules" figure:

This figure is an image embedded in a PDF. I can't seem to find the source document the image was created from. Do you know where I can find it?

I have contacted the original author to commit the source file.

You may find out who uploaded the file with git blame or git log.

Changes related to note 10 have been pushed.

Review of Introduction section at nfd-docs:commit:af09acb86be572703268d0e60bee55450abcaff8.

"Overview of NFD modules" figure:

• "face status publisher" is part of FaceManager, not part of "forwarder status manager"; it doesn't need to be mentioned, because StatusDataset is at the same level of ControlCommand, and ControlCommand is not separately listed.
• "FIB enumeration publisher" is part of FibManager, not part of "forwarder status manager"; it doesn't need to be mentioned, because StatusDataset is at the same level of ControlCommand, and ControlCommand is not separately listed.
• "face monitoring" has been moved to ndn-cxx.
• "network state monitoring" has been moved to ndn-cxx.

"How packets are processed in NFD" section:

• "A Face is split into a LinkService and a Transport" is better phrased as "A face is composed of a link service and a transport".
• Nack processing should be introduced either after Interest processing or after Data processing, not before Interest processing.
• What does "duplicate" mean in "If the Interest is not a duplicate"?
• It's unnecessary to mention the special case of admitting local unsolicited Data into ContentStore. This detail is irrelevant to the rest of this paragraph, and this feature is in the removal process.

"How management Interests are processed in NFD" section:

• "When NFD receives the command Interest" => "When NFD receives a control command request". At this point, there isn't a particular "command Interest" so "a" is better than "the". "control command request" is the term used in ControlCommand spec that refers to the Interest.
• "Notification streams .. operate slightly differently". The difference is not "slight".

Changes related to note 14 have been pushed.

Review of Introduction section at nfd-docs:commit:f936e1c8fa281ba395972a861a4ad3e90c797307.

"Overview of NFD modules" figure:

• "face events" is part of FaceManager; it doesn't need to be mentioned, because Notification Stream is at the same level of ControlCommand, and ControlCommand is not separately listed.

"How packets are processed in NFD" section:

• "Transport acts as an overlay" is wrong. It's a wrapper not an overlay.

Changes related to note 16 have been pushed.

Review of Introduction section at nfd-docs:commit:8c2ceec3492e9f7105569cd0e7dbb036885992a1.

"Overview of NFD modules" figure:

• "notification stream" should not be mentioned, because Notification Stream is at the same level of ControlCommand, and ControlCommand is not separately listed.

Revisions based upon note 18 have been pushed.