Project

General

Profile

Actions
Copy link

Task #3514

closed

Merge Channel test cases as template

Added by Junxiao Shi about 8 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Davide Pesavento
Category:
Faces
Target version:
v0.5
Start date:
Due date:
% Done:

100%

Estimated time:
3.00 h

Description

Merge similar test cases from UnixStreamChannel TcpChannel UdpChannel WebSocketChannel test suites into test case templates.

Related issues 4 (0 open — 4 closed)

Blocked by NFD - Task #3372: UnixStreamChannel: test suite improvementClosedSpencer Lee

Actions
Blocked by NFD - Task #3370: TcpChannel: test suite improvementClosedSpencer Lee

Actions
Blocked by NFD - Task #3371: UdpChannel: test suite improvementClosedSpencer Lee

Actions
Blocked by NFD - Task #3373: WebSocketChannel: test suite improvementClosedWeiwei Liu

Actions
Actions
Copy link
 #1

Updated by Junxiao Shi about 8 years ago

  • Blocked by Task #3372: UnixStreamChannel: test suite improvement added
Actions
Copy link
 #2

Updated by Junxiao Shi about 8 years ago

  • Blocked by Task #3370: TcpChannel: test suite improvement added
Actions
Copy link
 #3

Updated by Junxiao Shi about 8 years ago

  • Blocked by Task #3371: UdpChannel: test suite improvement added
Actions
Copy link
 #4

Updated by Junxiao Shi about 8 years ago

  • Blocked by Task #3373: WebSocketChannel: test suite improvement added
Actions
Copy link
 #5

Updated by Junxiao Shi about 8 years ago

  • Assignee set to Davide Pesavento

@Davide agrees to work on this in #3371 note-9.
This Task does not block 0.4.1 release.

Actions
Copy link
 #6

Updated by Davide Pesavento about 8 years ago

Where should the test case templates reside? channel.t.cpp?

Actions
Copy link
 #7

Updated by Alex Afanasyev about 8 years ago

How much duplication we have (i.e., is it worth effort)?

I would call it "channel-common.t.cpp", to highlight that it is not generic "channel" tests, but common tests of different channels. Though, name doesn't matter much.

Actions
Copy link
 #8

Updated by Davide Pesavento about 8 years ago

Alex Afanasyev wrote:

How much duplication we have (i.e., is it worth effort)?

TcpChannel and UdpChannel are practically identical. WebSocketChannel uses a substantially different model, so I probably won't be able to merge it. I haven't looked at UnixStreamChannel yet.

I would call it "channel-common.t.cpp", to highlight that it is not generic "channel" tests, but common tests of different channels. Though, name doesn't matter much.

Sounds good.

Actions
Copy link
 #9

Updated by Davide Pesavento over 7 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #10

Updated by Davide Pesavento over 7 years ago

  • Status changed from In Progress to Code review
  • % Done changed from 0 to 100

I was able to merge TcpChannel and UdpChannel suites relatively easily. UnixStreamChannel and WebSocketChannel have some deep differences that are not easy to overcome without making the code much more complex (and probably unreadable), albeit they do have a couple of test cases that look similar. I don't think trying to merge them is worth the effort though, and even then we would still have some special cases for each channel type.

Actions
Copy link
 #11

Updated by Davide Pesavento over 7 years ago

  • Status changed from Code review to Closed
Actions
Copy link

Also available in: Atom PDF