Feature #3517
closedUpgrade Gerrit to version 2.12.1 (or later)
100%
Description
A (non-exhaustive) list of reasons for upgrading follows:
(minor) Issue 3378: Improve the cursor style in side-by-side diff and inline editor.
Issue 3460: Fix regression in the search box auto-suggestions.
A change introduced in version 2.11 caused the auto-suggestions to not work any more.(not sure if we're affected but it sounds serious) JGit bug 468024: Fix data loss if a pack is pushed to a JGit based server and gc runs concurrently on the same repository.
(Flash must die) Prefer JavaScript clipboard API if available.
Modern versions of Chrome support a draft clipboard API from JavaScript that allows copying without use of a Flash widget. If the API appears to be available in the browser, it is now used instead of the Flash widget.
(and a later version enable it also for firefox)(I once commented on a draft change [uploaded by Junxiao IIRC] without knowing that it was a draft so all my comments were lost, that was very annoying) Issue 3478: Show correct status line for draft patch sets. If a new patch set was uploaded as draft to an existing published change, the status line did not reflect the draft status of the now current patch set.
Fix reviewer suggestion for accounts containing upper case letters. When an email for an account contained upper-case letter(s), this account couldn’t be added as a reviewer by selecting it from the suggested list of accounts.
(this is also quite annoying, searching with "/" is practically unusable at the moment) Fix highlighting of search results and trailing whitespaces in intraline diff chunks.
(this could be helpful for the admins) Submission of changes may include ancestors. If a change is submitted that has submittable ancestor changes, those
changes will also be submitted.(it happened a few times that I was looking for a comment, and I remembered who wrote it but not in what change) Add commentby: search operator to search by author of comments.
(this is probably the single most important feature I want... due to poor gerrit UX it happens to me all the time that I end up adding comments on older patch sets, usually when I'm viewing a diff from a patch set other than "base", and if I'm in a rush or forget to check, those comments don't get published) Issue 1100: Publish all draft comments when replying to a change. All draft comments, including those on older patch sets, are published when replying to a change.
(useful when multiple people are working on a change) Show uploader if different from change owner.
(minor, but still it would simplify my workflow a bit) commit-msg hook: Don’t add Change-Id line on temporary commits.
Commits created with git commit --fixup or git commit --squash are not intended to be pushed to Gerrit, and don’t need a Change-Id line. This also prevents changes from being accidentally uploaded, at least for projects that have the Require Change-Id configuration enabled.Issue 1207: Fix keyboard shortcuts for non-US keyboards on side-by-side diff screen.
v2.12 also includes "Support for GPG Keys and signed pushes" but probably we don't care. I'm just used to signing both commits and pushes due to the commit policies we enforce in Gentoo.
Updated by Alex Afanasyev over 9 years ago
I wanted to do an update for a long time, but was holding off for two two minor reasons:
the current version is the last that feature "old" interface. @Junxiao, I remember you were using the old interface. Will you be ready to rely on new interface? On iPad, the unified diff seem to be working well, while side-by-side not really.
Fear that OAuth2 plugin will not be broken (the current version includes patches that were under review at the time).
Updated by Junxiao Shi over 9 years ago
the current version is the last that feature "old" interface
The old interface (what we used in 2014) is already gone in current version 2.11-rc1-187-g323f27a
.
Issue 3257 is my biggest complaint for current version, which makes me unable to do code review on half of my devices.
Fear that OAuth2 plugin will not be broken
Deploy it in pre-production environment and have a try, before pushing to prod.
See also #2661.
Updated by Davide Pesavento over 9 years ago
Junxiao Shi wrote:
the current version is the last that feature "old" interface
The old interface (what we used in 2014) is already gone in current version
2.11-rc1-187-g323f27a
.
Issue 3257 is my biggest complaint for current version, which makes me unable to do code review on half of my devices.
Then this is not a blocker for the upgrade.
Updated by Alex Afanasyev over 9 years ago
- Status changed from New to Feedback
- % Done changed from 0 to 100
Upgraded to 2.12.2. Seem to be working properly.
Updated by Davide Pesavento over 9 years ago
I believe this ticket can be closed.
Updated by Alex Afanasyev over 9 years ago
- Status changed from Feedback to Closed