Project

General

Profile

Feature #3522

FaceUri syntax for netdev-bound faces

Added by Junxiao Shi about 3 years ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Utils
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
2.00 h

Description

Define FaceUri syntax for netdev-bound faces (#3521).

Update FaceUri parser to accept this syntax, which will be used in face dataset.


Related issues

Blocks NFD - Feature #3521: Netdev-bound facesIn Progress

History

#1 Updated by Junxiao Shi about 3 years ago

#2 Updated by Davide Pesavento about 3 years ago

This task should be moved to the ndn-cxx project.

#3 Updated by Junxiao Shi about 3 years ago

  • Project changed from NFD to ndn-cxx
  • Category changed from Faces to Utils
  • Target version changed from v0.5 to v0.5

FaceMgmt revision 51 defines the syntax.

#4 Updated by Davide Pesavento about 3 years ago

There's a small problem with the "%" sign, as I pointed out here http://redmine.named-data.net/issues/1428#note-4, and the percent-encoded version would be kind of ugly and harder to read in my opinion.

What were the other proposals for the syntax?

#5 Updated by Davide Pesavento over 2 years ago

  • Assignee deleted (Andrea Tosatto)
  • Start date deleted (03/08/2016)

#6 Updated by Junxiao Shi over 2 years ago

  • Assignee set to Weiwei Liu
  • Target version changed from v0.5 to v0.6

#7 Updated by Weiwei Liu over 2 years ago

  • Status changed from New to In Progress

#8 Updated by Jeff Burke over 2 years ago

Needs to target v0.5 of dependent Feature #3521.

#9 Updated by Davide Pesavento over 2 years ago

Jeff Burke wrote:

Needs to target v0.5 of dependent Feature #3521.

v0.5 has already been released, so v0.6 is the correct target.

#10 Updated by Junxiao Shi over 2 years ago

FaceMgmt revision 59 adds %25 to the syntax.

#11 Updated by Junxiao Shi over 2 years ago

  • Estimated time set to 2.00 h

#12 Updated by Weiwei Liu over 2 years ago

  • Status changed from In Progress to Code review

#13 Updated by Junxiao Shi over 2 years ago

when #1428 is eventually implemented, we might have a problem here... how do we distinguish the two?

How about changing the syntax to udp4+dev://eth1:6363?

#14 Updated by Davide Pesavento over 2 years ago

Junxiao Shi wrote:

How about changing the syntax to udp4+dev://eth1:6363?

Fine with me.

#15 Updated by Junxiao Shi over 2 years ago

FaceMgmt rev60 has the new syntax.

It's worth noting that the <port> part is required, and such FaceUris are always canonical.

#16 Updated by Junxiao Shi over 2 years ago

can't we add a default port during canonicalization?

There isn't a valid use case for that.
FaceUri for NIC-associated permanent faces are never intended to be entered by an operator. It can only be returned as the LocalUri in a faces/list or faces/query dataset. Therefore, they will always be constructed as canonical.

#17 Updated by Davide Pesavento over 2 years ago

Junxiao Shi wrote:

can't we add a default port during canonicalization?

There isn't a valid use case for that.
FaceUri for NIC-associated permanent faces are never intended to be entered by an operator. It can only be returned as the LocalUri in a faces/list or faces/query dataset. Therefore, they will always be constructed as canonical.

I know that. However there are things in FaceUri that are a little more generic and broader than the bare minimum required by NFD. For example there's a constructor taking an arbitrary scheme, even though we only need it for ws:// and wsclient://... Anyway, not a big deal, it can always be changed later.

#18 Updated by Junxiao Shi over 2 years ago

  • Status changed from Code review to Closed
  • % Done changed from 0 to 100

#19 Updated by Davide Pesavento 4 months ago

  • Subject changed from FaceUri syntax for NIC-associated permanent faces to FaceUri syntax for netdev-bound faces
  • Description updated (diff)

Also available in: Atom PDF