Feature #3588: Update WebSocket++ to 0.7.0 - NFD - NDN project issue tracking system

Feature #3588

closed

Update WebSocket++ to 0.7.0

Added by Davide Pesavento about 8 years ago. Updated almost 8 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Eric Newberry

Category:

Faces

Target version:

v0.5

Start date:

Due date:

% Done:

100%

Estimated time:

3.00 h

Description

The WebSocket++ project released version 0.7.0 on Feb 22th. We should update NFD submodule and build instructions to use that version.

Files

nfd-3588-test.tar (124 KB) nfd-3588-test.tar

Test run for original (NFD:891f47bc) and updated (NFD:25a84074)

Eric Newberry, 06/26/2016 03:45 PM

Related issues 1 (0 open — 1 closed)

Blocks NFD - Task #4614: Use system-default WebSocket++

Rejected

Actions

Issue # Delay: days Cancel

History
Notes
Property changes

Actions

Copy link

Updated by Junxiao Shi about 8 years ago

Subject changed from Update WebSocket++ to the latest upstream version to Update WebSocket++ to 0.7.0
Category set to Faces
Target version set to v0.5
Estimated time set to 3.00 h

Actions

Copy link

Updated by Eric Newberry almost 8 years ago

Was anyone already planning to work on this?

Actions

Copy link

Updated by Davide Pesavento almost 8 years ago

Eric Newberry wrote:

Was anyone already planning to work on this?

I don't think so, this task has no assignee. Feel free to take it.

Actions

Copy link

Updated by Eric Newberry almost 8 years ago

Status changed from New to In Progress
Assignee set to Eric Newberry

Actions

Copy link

Updated by Eric Newberry almost 8 years ago

Status changed from In Progress to Code review
% Done changed from 0 to 100

Actions

Copy link

Updated by Junxiao Shi almost 8 years ago

A manual test is needed before merging the Change http://gerrit.named-data.net/2891.

The test should deploy NFD with this patch, enable WebSocket listener, and confirm that apps can communicate over WebSocket transport.
The scenario should include bidirectional traffic.
If there's difficulty in prefix registration, nfdc register can be used to add a static route on the FaceId.

Also, confirm nfd-status -f output displays correct FaceUris.

Test report should indicate exact steps of the tests, apps being used and their versions (tag or commit hash), and the results.

Actions

Copy link

Updated by Eric Newberry almost 8 years ago

File nfd-3588-test.tar nfd-3588-test.tar added

I ran a test as directed in note 6. I ran the same test on both the unmodified (original) NFD (commit hash 891f47bc) and the updated commit (Gerrit revision #2 and commit hash 25a84074).

The other apps used had the following commits (or releases):

ndn-cxx 4f512fb2
ndn-tools d2300731
ndn-js 8964ac15
Firefox 47.0 (47.0+build3-0ubuntu0.16.04.1)

For the test, I wrote a simple app for ndn-js that ran in the browser. It first requested content from ndnpoke (prefix /test-content) and then served content at the prefix /nfd-3588 (the prefix was registered externally via nfdc). The content at /nfd-3588 was requested by ndnpeek. nfd-status -f was run and a screenshot was taken of the output of the ndn-js app in the browser.

From what I can see, it appears that the updated version of WebSocket++ works properly.

The output from both tests and the scripts used have been uploaded to this issue.

Actions

Copy link